Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Automatically detect and set minikube docker opts from kube context #25

Closed
r2d4 opened this issue Feb 2, 2018 · 0 comments · Fixed by #29
Closed

[Build] Automatically detect and set minikube docker opts from kube context #25

r2d4 opened this issue Feb 2, 2018 · 0 comments · Fixed by #29
Labels
area/build kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@r2d4
Copy link
Contributor

r2d4 commented Feb 2, 2018

Port this code and add tests

https://github.com/r2d4/skaffold/blob/master/pkg/skaffold/builder/minikube.go
@r2d4 r2d4 added kind/feature-request area/build priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Feb 2, 2018
@r2d4 r2d4 mentioned this issue Feb 3, 2018
Merged
@r2d4 r2d4 closed this as completed in #29 Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto detect minikube context and use minikube docker daemon
1 participant
@r2d4