Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Deployed Artifacts #98

Closed
dlorenc opened this issue Feb 22, 2018 · 4 comments
Closed

Track Deployed Artifacts #98

dlorenc opened this issue Feb 22, 2018 · 4 comments

Comments

@dlorenc
Copy link
Contributor

dlorenc commented Feb 22, 2018

Opening an issue to get some discussion started on how skaffold can keep track of what it's deploying through the various deployers we support (helm, kubectl apply, ksonnet, etc.).

Tracking these artifacts can help with things like #94 and deletion cases.

For kubectl, we know the manifest paths so we could parse those YAMLs and apply labels, or build a label selector?

For helm, we know the release names so we can query them with helm list or something similar.

@r2d4
Copy link
Contributor

r2d4 commented Feb 22, 2018

All tools eventually have to send real api object requests to the apiserver, so I’m not sure if that’s too strong of a requirement for the tools to spit out those.

For the tools that simply template and then apply, it’s trivial. Helm also has a way to output the “released” resources in YAML form.

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 2, 2018

Some more ideas: Add a list of deployed runtime.Objects to the BuildResult

For Helm, populate this via helm get
For kubectl, populate this by parsing the yamls we're about to deploy

It looks like this is the best way to parse YAML files currently:
kubernetes/client-go#193

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 2, 2018

Here's a functioning yaml parsing snippet:
https://gist.github.com/dlorenc/2ac000a25656447a0c06e79150407b4c

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 3, 2018

cc @nkubala this is the issue I was referring to yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants