Remove the rust-gpu-toy and create a single workspace #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realistically, this wasn't going to get updated, especially as it uses a non-standard fork. The requirement to use nightly also prevents making the rest of the items into a single workspace, thus bloating the target directories, and making the rust-analyzer experience worse
|
I'd also be tempted to remove the piet-gpu-hal example too - it currently uses a version from over a year ago (linebender/vello@8b65942), and a naïve upgrade gives a number of errors. The method of using ninja to create the files is really not user friendly to a rust user, so I'm not sure how to run the builds - there seem to be a number of environment dependencies. I'm also not sure how to update the build system to add dxil support. However, it can also be left at present - the current form does still run, after all. |
raphlinus
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realistically, this wasn't going to get updated, especially as it uses a non-standard fork.
The requirement to use nightly also prevents making the rest of the items into a single workspace, thus bloating the target directories, and making the rust-analyzer experience worse.
This also makes the window for
compute-shader-toynon-resizable, because resizing is currently not supported. The example window forpiet-compute-toyis pre-existingly non-resizable, although I have not inspected the code to fully copy its setup.