Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New check: Check that U+FBB2–FBC2 are not marks #4295

Closed
2 of 7 tasks
khaledhosny opened this issue Oct 5, 2023 · 0 comments
Closed
2 of 7 tasks

New check: Check that U+FBB2–FBC2 are not marks #4295

khaledhosny opened this issue Oct 5, 2023 · 0 comments
Assignees
@felipesanches
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone
0.10.2

Comments

@khaledhosny
Copy link
Contributor

khaledhosny commented Oct 5, 2023 •
edited

What needs to be checked?

Check that the Arabic dot symbols are not marks in GDEF.

Detailed description of the problem

Unicode has a few spacing symbols representing Arabic dots and other marks, but they are purposefully not classified as marks. Many fonts mistakenly classify them as marks.

Resources and steps needed to reproduce the problem

The current version of Noto Sans Arabic ans Noto Naskh Arabic has this issue.

Suggested profile

  • Vendor-specific: Google Fonts
  • Vendor-specific: Adobe Fonts
  • OpenType (requirements imposed by the OpenType specification)
  • Universal (broadly accepted best practices on the type design community)
  • Other:

Suggested result

  • 🔥 FAIL (An issue that must be corrected for the font to function properly)
  • ⚠️ WARN (A potential issues that may need to be addressed)

Severity assessment

4 as making them marks make them unsuitable for there original purpose (stand-alone symbols to used in pedagogical contexts discussing Arabic consonantal marks).
@khaledhosny khaledhosny added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Oct 5, 2023
@felipesanches felipesanches added this to the 0.10.2 milestone Oct 20, 2023
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 20, 2023
@felipesanches
New checks: Arabic spacing symbols aren't classified as marks.
5f2de87 
Unicode has a few spacing symbols (U+FBB2–FBC1) representing Arabic dots and other marks,
but they are purposefully not classified as marks.

Many fonts mistakenly classify them as marks, making them unsuitable
for their original purpose as stand-alone symbols to used in pedagogical
contexts discussing Arabic consonantal marks.

Added to the Universal Profile
com.google.fonts/check/arabic_spacing_symbols (experimental)
(issue fonttools#4295)
@felipesanches felipesanches mentioned this issue Oct 20, 2023
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 20, 2023
@felipesanches
New checks: Arabic spacing symbols aren't classified as marks.
07d8fcc 
Unicode has a few spacing symbols (U+FBB2–FBC1) representing Arabic dots and other marks,
but they are purposefully not classified as marks.

Many fonts mistakenly classify them as marks, making them unsuitable
for their original purpose as stand-alone symbols to used in pedagogical
contexts discussing Arabic consonantal marks.

Added to the Universal Profile
com.google.fonts/check/arabic_spacing_symbols (experimental)
(issue fonttools#4295)
felipesanches added a commit that referenced this issue Oct 20, 2023
@felipesanches
New checks: Arabic spacing symbols aren't classified as marks.
eeb87c8 
Unicode has a few spacing symbols (U+FBB2–FBC1) representing Arabic dots and other marks,
but they are purposefully not classified as marks.

Many fonts mistakenly classify them as marks, making them unsuitable
for their original purpose as stand-alone symbols to used in pedagogical
contexts discussing Arabic consonantal marks.

Added to the Universal Profile
com.google.fonts/check/arabic_spacing_symbols (experimental)
(issue #4295)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 28, 2023
@felipesanches
check/arabic_spacing_symbols - remove experimental status
3616075 
Originaly implemented in v0.10.2
No longer marked as experimental.

On the Universal Profile
com.google.fonts/check/arabic_spacing_symbols
"Check that Arabic spacing symbols U+FBB2–FBC1 aren't classified as marks."
(issue fonttools#4295)
@felipesanches felipesanches mentioned this issue Nov 28, 2023
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Nov 28, 2023
@felipesanches
check/arabic_spacing_symbols - remove experimental status
386c35e 
Originally implemented in v0.10.2
No longer marked as experimental.

On the Universal Profile
com.google.fonts/check/arabic_spacing_symbols
"Check that Arabic spacing symbols U+FBB2–FBC1 aren't classified as marks."
(issue fonttools#4295)
felipesanches added a commit that referenced this issue Nov 28, 2023
@felipesanches
check/arabic_spacing_symbols - remove experimental status
e9cb7ce 
Originally implemented in v0.10.2
No longer marked as experimental.

On the Universal Profile
com.google.fonts/check/arabic_spacing_symbols
"Check that Arabic spacing symbols U+FBB2–FBC1 aren't classified as marks."
(issue #4295)
@dscorbett dscorbett mentioned this issue Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Milestone
0.10.2
Development

No branches or pull requests
3 participants
@khaledhosny @felipesanches @eliheuer