Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version of CFF/CFF2 profile with checks for max call depth #2425

Closed
wants to merge 2 commits into from

Conversation

cjchapman
Copy link
Member

@cjchapman cjchapman commented Mar 28, 2019

Description

This PR represents the start of a CFF/CFF2 profile (which is included in the opentype profile) with two new checks that traverse the CFF or CFF2 subroutine call tree to ensure that the max call depth of 10 is not exceeded:

  • com.adobe.fonts/check/cff_call_depth Is the CFF subr/gsubr call depth > 10?
  • com.adobe.fonts/check/cff2_call_depth Is the CFF2 subr/gsubr call depth > 10?

also included are CFF and CFF2 test fonts with glyphs that have varying call depths, specifically:

'B' -- max call depth: 9
'C' -- max call depth: 10
'D' -- max call depth: 11
'E' -- max call depth: 12
'F' -- calls a gsubr that calls itself for infinite recursion

To Do

  • update CHANGELOG.md
  • wait for checks to pass (except github/pages, which is stuck)
  • request a review

@felipesanches
Copy link
Collaborator

This looks really good :-)

I will try to merge this after merging #2426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants