Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.glyphs parsing failures #851

Open
cmyr opened this issue Jun 13, 2024 · 2 comments
Open

.glyphs parsing failures #851

cmyr opened this issue Jun 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cmyr
Copy link
Member

cmyr commented Jun 13, 2024

After running fontc on ~480 fonts hosted by google fonts, a full ~100 of them failed to compile due to errors while parsing .glyphs files.

  • the majority of these (74) relate to unknown/legacy glyph categories, like "Uppercase" and "Smallcaps" (which I think are now subcategories?) As well as "Other" (which we should parse?) and the empty string, which we should treat as no category.
  • 21 of these are "Oops this parser is just broken"
  • 2 of these are 'unexpected character' during parsing
  • 1 of these is 'Unknown escape code'.

so the first of these should be easy enough to solve, and the others are tbd (but I'm optimistic)

@rsheeter
Copy link
Contributor

Two requests:

  1. Document how to run on lots of fonts on the root index, it's a useful tool
  2. Capture specific examples, e.g. clone this repo and build this file. Ideally the crater-esque run would report that.

@rsheeter rsheeter added the bug Something isn't working label Jun 13, 2024
@rsheeter
Copy link
Contributor

Did you happen to run ttx_diff on the ~380 that did compile? - would be very interested in our starting position for both how many compile and how many pass so we can see the improvement over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants