Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Read-only' / Reviewer mode #1050

Closed
BlackFoundry opened this issue Jan 9, 2024 · 3 comments · Fixed by googlefonts/fontra-rcjk#145 or googlefonts/fontra-rcjk#146
Closed

'Read-only' / Reviewer mode #1050

BlackFoundry opened this issue Jan 9, 2024 · 3 comments · Fixed by googlefonts/fontra-rcjk#145 or googlefonts/fontra-rcjk#146
Assignees

Comments

@BlackFoundry
Copy link
Collaborator

BlackFoundry commented Jan 9, 2024

It will soon become necessary to have users with read-only access for reviewers.

They should be able to leave comments and notes directly on a Fontra project. (See #58)

Perhaps also have the ability to change the status field of glyphs to mark them 'validated' or any checking preceding step.

@justvanrossum
Copy link
Collaborator

Also relates to #58

@justvanrossum
Copy link
Collaborator

Let's separate the read-only mode from comments/annotations. The former is being implemented and is fairly simple, but a proper review system with comments / annotation is a serious project that requires design preparations and planning. Let's use issue #58 for that.

@justvanrossum justvanrossum added this to the January issues / sprint milestone Jan 15, 2024
@justvanrossum justvanrossum self-assigned this Jan 15, 2024
@justvanrossum
Copy link
Collaborator

For now, we want three modes:

  • full editing capabilities
  • read-only, selection is possible, but attempting to edit does not work (perhaps shows a dialog)
  • "dummy editing": editing is possible, but changes are not written to the backend (this is the current behavior when for example opening a TTF). This is nice to have so someone can play around, get familiar, yet can't destroy the underlying data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment