Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glyphsLib should be split into two modules #680

Open
simoncozens opened this issue Apr 12, 2021 · 4 comments
Open

glyphsLib should be split into two modules #680

simoncozens opened this issue Apr 12, 2021 · 4 comments

Comments

@simoncozens
Copy link
Collaborator

glyphsLib currently does two very different and orthogonal things:

  • provides a Python interface to the Glyphs file format (read/write/manipulate).
  • Converts between GS* objects and UFO files.

Obviously I get the idea that people who manipulate .glyphs files will often want to then turn them into UFO files, but (a) not necessarily - there are other things that can be done with Glyphs files! and (b) glyphsLib is not the only source of GS* objects (Glyphs being the obvious other one). Currently glyphsLib is a combination refrigerator/microwave. I would rather have a separate refrigerator and microwave.

@madig
Copy link
Collaborator

madig commented Apr 21, 2021

Agree. After a split, the parser and object hierarchy could also be refactored to be less incomprehensible (does glyphLib need to be a potential frontend for the actual Glyphs.app or can we toss the proxies?). glyphsLib is currently off our agenda though, so i'm not expecting to be working on this anytime soon.

@simoncozens
Copy link
Collaborator Author

glyphsLib is currently off our agenda though

Um. Is anyone actually actively maintaining this package? (Looks over sadly at the glyphs3 PR.)

@belluzj
Copy link
Collaborator

belluzj commented Apr 21, 2021

I'm meaning to review the glyphsLib 3 PR eventually but as we haven't made the move to glyphs 3 at Dalton Maag, it's lower on my priority list and will take me longer than other reviews because I'll have to install glyphs 3 and look at some files and also the MR is huge...

@belluzj
Copy link
Collaborator

belluzj commented Apr 21, 2021

glyphsLib is currently off our agenda though

To clarify: it's not off the agenda completely, it's just that it's lower in the priority list than it used to be, because it's working OK for Glyphs 2 at the moment (we still have issues from time to time, as MRs from Tom show). But we're still very much using it.

Who is actively using glyphsLib with Glyphs 3? Maybe these users can help you validate your merge request at least from the point of view of functionality (i.e. round-tripping various Glyphs 3 projects and reporting what gets lost in the round-trip. That's a good indication of what your work can/can't handle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants