Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unencoded Glyphs Missing from /data/results/ .glyphs files #166

Closed
weiweihuanghuang opened this issue Apr 9, 2024 · 2 comments
Closed

Comments

@weiweihuanghuang
Copy link

weiweihuanghuang commented Apr 9, 2024

Trying to wrap my head around the new glyphsets tool. I looked in the /data/results .glyphs files but many of the unencoded glyphs from the previous glyph sets are missing, for example in GF_Latin_Plus.glyphs, the sets of numerals (*.tf *.numr, *.dnom) are no longer there.

Should I just refer to the archived .glyphs character sets for now?

@yanone
Copy link
Collaborator

yanone commented Apr 9, 2024

The changes should have been preserved. I'll investigate this. This looks like a mistake. There may be more glyphs missing from other glyphsets, so I'll go over them one by one another time.

In the meantime, rather than looking into the "Archive" folder, it's better to go back in time of the repository. This file version from half a year ago should be unchanged from what you know: https://github.com/googlefonts/glyphsets/blob/50f81f78473d9c72e4d19ddf378a7c532c4e86ad/GF_glyphsets/Latin/glyphs/GF_Latin_Plus.glyphs

@yanone
Copy link
Collaborator

yanone commented Apr 10, 2024

I found missing unencoded glyphs for Latin_Plus and Latin_Vietnamese and added them back.
Thanks for catching that.
I won't publish a new package right away as I'm about to make more changes, but the updated files are now available in the /data/results folder.

@yanone yanone closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants