Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flattenComponents breaks composed positioning on nested + transformed combining accent #435

Closed
arrowtype opened this issue Nov 25, 2020 · 3 comments

Comments

@arrowtype
Copy link

I have attempted to use the flattenComponents filter in a UFO based on the advice here: fonttools/fontbakery#2961 (comment)

<key>com.github.googlei18n.ufo2ft.filters</key>
    <array>
      <dict>
        <key>name</key>
        <string>flattenComponents</string>
        <key>pre</key>
        <integer>1</integer>
      </dict>
    </array>

It mostly works well! However, a notable exception is that my caroncomb accents, which are actually composed of the circumflexcomb rotated 180°. These caroncombs are decomposed, which is good, but the alignment in glyphs using them gets messed up once I use FontMake to export to a TTF:

misaligned flattened components

image

By comparison, here is a TTF built from a UFO that didn’t have a flattenComponents filter:

good components alignment

These are not open-source UFOs, so I can try to report back later with an OS reproduction case, if that is needed to diagnose & fix this problem.

@anthrotype
Copy link
Member

you may want to try using the decomposeTransformedComponents filter before the flattenComponents

@arrowtype
Copy link
Author

Thanks for the quick response! It works like a charm. 👍

image

Cheers! Feel free to close this issue if you feel that this is handled as expected.

@anthrotype
Copy link
Member

I would think so, yes. Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants