Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go get does not work for open-match.dev/open-match #675

Closed
djsell opened this issue Jul 19, 2019 · 5 comments
Closed

Go get does not work for open-match.dev/open-match #675

djsell opened this issue Jul 19, 2019 · 5 comments
Assignees
Milestone

Comments

@djsell
Copy link

djsell commented Jul 19, 2019

I tried to use go get to use the pb package to make a director that works with agones. I ran into a couple issues.

  1. Go get does not work for open-match.dev/open-match
$ go get -v open-match.dev/open-match
Fetching https://open-match.dev/open-match?go-get=1
Parsing meta tags from https://open-match.dev/open-match?go-get=1 (status code 200)
get "open-match.dev/open-match": found meta tag get.metaImport{Prefix:"open-match.dev/open-match", VCS:"git", RepoRoot:"https://github.com/googleforgames/open-match.git"} at https://open-match.dev/open-match?go-get=1
go: open-match.dev/open-match@v0.5.1: parsing go.mod: unexpected module path "github.com/GoogleCloudPlatform/open-match"
go: error loading module requirements

So I went ahead and got go get to work by using GoogleCloudPlatform/open-match

$ go get -v github.com/GoogleCloudPlatform/open-match
go: finding github.com/GoogleCloudPlatform/open-match v0.5.1
go: downloading github.com/GoogleCloudPlatform/open-match v0.5.1
go: extracting github.com/GoogleCloudPlatform/open-match v0.5.1
github.com/GoogleCloudPlatform/open-match
  1. There seems to be some problem when trying to use the agones API and open-match API in the same project. I was seemingly having problems with kubernetes client version dependencies once I had both included in a single project using go modules.
$ go run main.go director
go: finding k8s.io/api/admissionregistration/v1alpha1 latest
go: finding k8s.io/api/admissionregistration latest
go: finding k8s.io/api latest
build command-line-arguments: cannot load k8s.io/api/admissionregistration/v1alpha1: cannot find module providing package k8s.io/api/admissionregistration/v1alpha1

Kubernetes api was working just fine when I had only agones integrated.

@djsell djsell changed the title Go get does not work Go get does not work for open-match.dev/open-match Jul 19, 2019
@Laremere
Copy link

Thanks for trying open match and reporting this issue.

I was able to repo the first issue. It looks like we never updated the url for the 0.5, though that seems fine (imo) as the old go get does work.

We're in the process of releasing 0.6.0, which (among other things) has a reworked API. So I recommend running instead:

go get -v open-match.dev/open-match@v0.6.0-rc.1

If you use this version, does it fix your other problem? Otherwise please include a concrete list of steps that I can run in an empty folder for reproduction. Given that I don't have contents of your directory, it would take random guessing to reproduce your issue.

Thanks!

@Laremere
Copy link

Also I should note that once we release v0.6.0, that will fix the go get problem without needing to tag the version. It's only that go get by default picks that latest version but ignores release candidates.

@djsell
Copy link
Author

djsell commented Jul 20, 2019

Using go get -v open-match.dev/open-match@v0.6.0-rc.1 fixed both issues!

Thanks for the fast response.

@Laremere
Copy link

Jeremy wanted to look at this to see if we can improve the user experience while we are in the 0.6 rc process.

@jeremyje
Copy link
Contributor

This looks like fallout from the transition to googleforgames org. You might have to delete your rm -rf $GOPATH/pkg (make sure that $GOPATH is actually set otherwise you'll delete /pkg!) directory and rebuild as the proper workaround here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants