Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed renderer selection from the samples #1430

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Dec 6, 2023

The current PRs removes the renderer selection from our samples.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1429 馃

@wangela
Copy link
Contributor

wangela commented Dec 6, 2023

3 files are failing header check. Can we try changing the format to remove the (C) so it just reads Copyright 2023 The Android Open Source Project and see if that satisfies it?

@kikoso
Copy link
Collaborator Author

kikoso commented Dec 6, 2023

3 files are failing header check. Can we try changing the format to remove the (C) so it just reads Copyright 2023 The Android Open Source Project and see if that satisfies it?

That is a funny one, we have it in several files, but only three triggered the failure. Changed it, if more files fail will replace it project-wide.

@wangela
Copy link
Contributor

wangela commented Dec 6, 2023

Yay that passed header-check!

@wangela wangela merged commit 596b127 into main Dec 6, 2023
11 checks passed
@wangela wangela deleted the feat/removed_renderer_selection branch December 6, 2023 22:55
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 1.8.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove renderer check from the app
3 participants