Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose raw GoogleMap for extensibility #135

Closed
arriolac opened this issue Jun 6, 2022 · 2 comments · Fixed by #140
Closed

Expose raw GoogleMap for extensibility #135

arriolac opened this issue Jun 6, 2022 · 2 comments · Fixed by #140
Assignees
Labels
released triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@arriolac
Copy link
Member

arriolac commented Jun 6, 2022

Is your feature request related to a problem? Please describe.
Currently, there is a need for developers to extend the functionality provided by Maps Compose. For example, there's much need to use features in the Utility Library alongside the Maps Compose library. However, using the Utility Library involves rewriting some of the Maps Compose features manually which is not ideal and brings us back to square one.

Describe the solution you'd like
Consider an approach that would allow developers to obtain a handle to the GoogleMap Maps SDK object to make direct manipulations to it. This would allow developers to extend the map and use utility library features. One approach would be to expose a MapEffect composable that exposes the GoogleMap

e.g.

GoogleMap() {
    MapEffect { googleMap ->
        // use googleMap w/ clustering
    }
}

Another option is to provide a CompositionLocal of the GoogleMap.

Note: this may have some unintended consequences given that Maps Compose manages the map's properties and so it would have to be made very clear to developers how this should be used.

Describe alternatives you've considered
Proposal in #28 is related.

Additional context
See conversation in #44

@arriolac arriolac added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Jun 6, 2022
@arriolac arriolac assigned arriolac and unassigned barbeau Jun 6, 2022
@arriolac
Copy link
Member Author

arriolac commented Jun 6, 2022

@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
3 participants