Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BEVEL style for start and end caps of the polylines #341

Closed
vladcioricagoogle opened this issue Jul 21, 2023 · 5 comments
Closed

Add BEVEL style for start and end caps of the polylines #341

vladcioricagoogle opened this issue Jul 21, 2023 · 5 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vladcioricagoogle
Copy link

This is needed for achieving a straight line between polylines with different colors. Current ButtCap is not joining the polylines in a smooth way because it leaves open spaces on curves.

@vladcioricagoogle vladcioricagoogle added triage me I really want to be triaged. type: question Request for information or clarification. Not an issue. labels Jul 21, 2023
@wangela
Copy link
Member

wangela commented Jul 21, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@vladcioricagoogle Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@wangela
Copy link
Member

wangela commented Jul 24, 2023

After we merge #338 to upgrade to Maps SDK 18.1.0 which supports polyline customization, it will be easier to achieve this. The supported options in 18.1.0 for customizing start and end caps are ButtCap (default), RoundCap, SquareCap, and CustomCap. Would RoundCap satisfy your use case for curves?

@wangela wangela added needs more info This issue needs more information from the customer to proceed. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. labels Jul 24, 2023
@vladcioricagoogle
Copy link
Author

Not really. current SDK already supports ButtCap RoundCap and SquareCap but it doesn't know how to join polylines with different colours in curves for the ButtCap. We will need something similar to what Google Maps is doing for drawing polylines with traffic mode on (where there are multiple colors). Can we achieve something like that for this SDK?

@wangela wangela removed needs more info This issue needs more information from the customer to proceed. triage me I really want to be triaged. labels Jul 26, 2023
@wangela
Copy link
Member

wangela commented Jul 26, 2023

The best place to request a BevelCap type is in the Issue Tracker for Maps SDK for Android. In the meantime, if you need it sooner, you can generate CustomCap bitmaps that meet your needs.

@wangela wangela closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2023
@wangela
Copy link
Member

wangela commented Jul 28, 2023

Just a note, the current draft implementation for Polylines selects ButtCap; we may need a separate PR to support all cap types. Up to @lenoch0d if you want to add cap types to #308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants