Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add camera specific flow events and deprecate cameraEvents(). #113

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

arriolac
Copy link
Contributor

Adds camera flow events and deprecates cameraEvents(). See #111 for reasoning.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2021
@arriolac arriolac changed the title feat: Add camera specific flow events and deprecate camerarEvents(). feat: Add camera specific flow events and deprecate cameraEvents(). Feb 17, 2021
@arriolac arriolac changed the base branch from main to kotlin-flow February 17, 2021 16:06
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (kotlin-flow@1cd5586). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8e1e01c differs from pull request most recent head 032ef19. Consider uploading reports for the commit 032ef19 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             kotlin-flow    #113   +/-   ##
=============================================
  Coverage               ?   0.00%           
=============================================
  Files                  ?      28           
  Lines                  ?     222           
  Branches               ?      27           
=============================================
  Hits                   ?       0           
  Misses                 ?     222           
  Partials               ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd5586...032ef19. Read the comment docs.

@arriolac arriolac marked this pull request as draft February 18, 2021 01:14
@arriolac arriolac marked this pull request as ready for review February 18, 2021 01:15
@arriolac arriolac force-pushed the chris/kotlin-flow/camera branch 2 times, most recently from ddc282e to b8bf7b7 Compare April 7, 2021 20:13
@arriolac arriolac merged commit ce77946 into kotlin-flow Apr 7, 2021
@arriolac arriolac deleted the chris/kotlin-flow/camera branch April 7, 2021 20:48
arriolac added a commit that referenced this pull request Jun 7, 2021
* feat: Add camera specific flow events and deprecate cameraEvents(). (#113)

* feat: Add circleClickEvents() (#131)

* feat: Add groundOverlayClicks() (#132)

* feat: Add indoorStateChangeEvents() (#138)

* feat: Add indoorStateChangeEvents()

* Update demo to use local maps-ktx

* feat: Add flow support for info window events. (#139)

* feat: Add more flow events

Added the following APIs:
* mapClickEvents()
* mapLongClickEvents()
* markerClickEvents()
* markerDragEvents()
* myLocationButtonClickEvents()

* chore: Bump Maps version to 17.0.1 and compile/target sdk to 30

* feat: Add remaining flow extensions

Added the following APIs:

* myLocationClickEvents()
* poiClickEvents()
* polygonClickEvents()
* polylineClickEvents()

* feat: Add flow extensions to StreetViewPanoramaView.
googlemaps-bot pushed a commit that referenced this pull request Jun 7, 2021
# [3.1.0](v3.0.1...v3.1.0) (2021-06-07)

### Features

* Add Kotlin Flow extensions for maps-ktx and maps-v3-ktx ([#144](#144)) ([e5cc99f](e5cc99f)), closes [#113](#113) [#131](#131) [#132](#132) [#138](#138) [#139](#139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant