Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assign unique package names to libs. #137

Merged
merged 1 commit into from
May 4, 2021
Merged

fix: Assign unique package names to libs. #137

merged 1 commit into from
May 4, 2021

Conversation

arriolac
Copy link
Member

@arriolac arriolac commented May 3, 2021

Builds were presenting a warning when the maps-utils-ktx library is used since the manifest package name conflicts with the utility library's package name. This change assigns unique package names to each lib in this repo.

Fixes #135 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@eae5bd4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #137   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      28           
  Lines           ?     202           
  Branches        ?      27           
======================================
  Hits            ?       0           
  Misses          ?     202           
  Partials        ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae5bd4...ac750f5. Read the comment docs.

@arriolac arriolac merged commit 49ef442 into main May 4, 2021
@arriolac arriolac deleted the chris/fix/135 branch May 4, 2021 15:10
googlemaps-bot pushed a commit that referenced this pull request May 4, 2021
## [3.0.1](v3.0.0...v3.0.1) (2021-05-04)

### Bug Fixes

* Assign unique package names to libs. ([#137](#137)) ([49ef442](49ef442))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate package name build warning
2 participants