Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null check in onAnimationUpdate #1161

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: null check in onAnimationUpdate #1161

merged 1 commit into from
Aug 23, 2023

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Feb 21, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Edit the title of this pull request with a semantic commit prefix (e.g. "fix: "), which is necessary for automated release workflows to decide whether to generate a new release and what type it should be.
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1160 馃

@google-cla
Copy link

google-cla bot commented Feb 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kikoso
Copy link
Collaborator

kikoso commented Aug 8, 2023

Hi @m1ga . Could you sign the CLA from Google? We need that formalism before getting a PR merged.

@m1ga
Copy link
Contributor Author

m1ga commented Aug 8, 2023

Hi @m1ga . Could you sign the CLA from Google? We need that formalism before getting a PR merged.

done

@wangela wangela requested a review from kikoso August 10, 2023 23:40
@JackHurst0
Copy link

@wangela @kikoso is there a plan to get this PR merged and released? >1% of users on my app are hitting this crash.

@wangela
Copy link
Member

wangela commented Aug 23, 2023

Sorry for the delay, @m1ga. Thanks for letting us know about the size of impact on your users, @JackHurst0. Releasing now!

@wangela wangela merged commit 3a5e35e into googlemaps:main Aug 23, 2023
1 check passed
googlemaps-bot pushed a commit that referenced this pull request Aug 23, 2023
@semantic-release-bot
chore(release): 3.5.3 [skip ci]
46bca38 
## [3.5.3](v3.5.2...v3.5.3) (2023-08-23)

### Bug Fixes

* null check in onAnimationUpdate ([#1161](#1161)) ([3a5e35e](3a5e35e))
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 3.5.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@m1ga m1ga deleted the nullCheck branch September 26, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoso kikoso kikoso approved these changes

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null object reference in onAnimationUpdate
5 participants
@m1ga @kikoso @JackHurst0 @wangela @googlemaps-bot