Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupling between DefaultClusterRenderer and NonHierarchicalDistanceBasedAlgorithm ? #70

Closed
jbandi opened this issue Mar 25, 2014 · 3 comments
Labels

Comments

@jbandi
Copy link

jbandi commented Mar 25, 2014

In the DefaultClusterRenderer the constant NonHierarchicalDistanceBasedAlgorithm.MAX_DISTANCE_AT_ZOOM is used.

Is this a problem?

For me this is a problem, since I would like to make the MAX_DISTANCE_AT_ZOOM configurable. So I can control the "granularity of clusters".

Furthermore I am wondering how this works when using the GridBasedAlgorithm? I guess it is just working because GridBasedAlgorithm.GRID_SIZE has the same value as NonHierarchicalDistanceBasedAlgorithm.MAX_DISTANCE_AT_ZOOM... or am I overlooking something here?

Would it be an approach to introduce a method getMaxDistanceAtZoom on Algorithm and then inject an Algorithm into the DefaultClusterRenderer?
I could do that and issue a Pull-Request ...

@artworkad
Copy link

👍 need this too

Currently I achieve this by defining a custom algorithm with the code of the NonHierarchicalDistanceBasedAlgorithm, I just changed the MAX_DISTANCE_AT_ZOOM value.

@stale
Copy link

stale bot commented Oct 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label Oct 3, 2019
@stale
Copy link

stale bot commented Nov 2, 2019

Closing this. Please reopen if you believe it should be addressed. Thank you for your contribution.

@stale stale bot closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants