Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sets the correct permissions on PlacesClient.awaitFindCurrentPlace @RequiresPermission annotation #231

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: sets the correct permissions on PlacesClient.awaitFindCurrentPlace @RequiresPermission annotation #231

merged 1 commit into from
Feb 7, 2024

Conversation

dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Feb 6, 2024

name: Pull request
about: Create a pull request
label: 'triage me'

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@dkhawk dkhawk linked an issue Feb 6, 2024 that may be closed by this pull request
PlacesClient.awaitFindCurrentPlace has an incorrect set of permissions in the @RequiresPermission annotation #230
Closed
kikoso
kikoso approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe we could consider adding a small comment on why we do not need to access the WiFi permission (reason: it is already added to the library manifest):

https://developers.google.com/maps/documentation/places/android-sdk/reference/com/google/android/libraries/places/api/net/PlacesClient

@dkhawk
Copy link
Contributor Author

dkhawk commented Feb 7, 2024

Looks good! Maybe we could consider adding a small comment on why we do not need to access the WiFi permission (reason: it is already added to the library manifest):

https://developers.google.com/maps/documentation/places/android-sdk/reference/com/google/android/libraries/places/api/net/PlacesClient

I'm not sure value in documenting something that the user does not need to do. Seem unnecessary.

@dkhawk dkhawk merged commit 791ec4f into main Feb 7, 2024
9 checks passed
@dkhawk dkhawk deleted the 230-placesclientawaitfindcurrentplace-has-an-incorrect-set-of-permissions-in-the-requirespermission-annotation branch February 7, 2024 15:00
googlemaps-bot pushed a commit that referenced this pull request Feb 7, 2024
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
449576f 
## [3.1.1](v3.1.0...v3.1.1) (2024-02-07)

### Bug Fixes

* sets the correct permissions on PlacesClient.awaitFindCurrentPlace @RequiresPermission annotation ([#231](#231)) ([791ec4f](791ec4f))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoso kikoso kikoso approved these changes

Assignees

@wangela wangela

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlacesClient.awaitFindCurrentPlace has an incorrect set of permissions in the @RequiresPermission annotation
4 participants
@dkhawk @googlemaps-bot @kikoso @wangela