Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed NPE on OnMapAndViewReadyListener #1116

Merged
merged 1 commit into from
Dec 23, 2022
Merged

fix: fixed NPE on OnMapAndViewReadyListener #1116

merged 1 commit into from
Dec 23, 2022

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Nov 29, 2022

The current NPE fixes an NPE that can potentially happen in any Activity using OnMapAndViewReadyListener

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #505 馃

@kikoso kikoso added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Nov 29, 2022
@kikoso kikoso requested a review from wangela November 29, 2022 16:32
@kikoso kikoso mentioned this pull request Nov 29, 2022
Closed
@amuramoto amuramoto assigned wangela and unassigned amuramoto Nov 29, 2022
@kikoso kikoso force-pushed the fix/fix_npe_in_onmapandviewreadylistener branch from d27695e to 1f3c38b Compare December 21, 2022 10:07
@kikoso kikoso changed the title Fixed NPE on OnMapAndViewReadyListener fix: fixed NPE on OnMapAndViewReadyListener Dec 21, 2022
@wangela wangela merged commit 71f1f67 into main Dec 23, 2022
@wangela wangela deleted the fix/fix_npe_in_onmapandviewreadylistener branch December 23, 2022 12:22
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 1.6.4 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApiDemos:Uninitialized mapView in OnMapAndViewReadyListener will cause crash
4 participants
@kikoso @googlemaps-bot @wangela @amuramoto