Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to determine if UTCOffset is 0 or unavailable in PlaceDetailsResult? #157

Closed
pranas opened this issue Aug 16, 2018 · 3 comments · Fixed by #158
Closed

How to determine if UTCOffset is 0 or unavailable in PlaceDetailsResult? #157

pranas opened this issue Aug 16, 2018 · 3 comments · Fixed by #158
Labels
released

Comments

@pranas
Copy link
Contributor

pranas commented Aug 16, 2018

The field is declared as int which means it cannot be nil and will be 0 if not set. However 0 is also a potential value of UTCOffset. How to tell whether UTCOffset is 0 or it's actually unavailable?
@domesticmouse
Copy link
Contributor

If you want to submit a PR with a change to int* and a matching test I'll happily review and accept it. =)

@pranas
Copy link
Contributor Author

pranas commented Aug 18, 2018

Ok, I will.

@pranas pranas mentioned this issue Aug 18, 2018
Merged
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make UTCOffset nil when unavailable pranas/google-maps-services-go
3 participants
@domesticmouse @pranas @googlemaps-bot