Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing placetypes #288

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

GuyKachur
Copy link
Contributor

@GuyKachur GuyKachur commented Sep 12, 2023

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

I didnt open an issue this feels pretty straight forward but i can open one if you want. Drugstore doesnt follow the other store in that its not separated but drugstore is the correct type according to the website.
https://developers.google.com/maps/documentation/places/web-service/supported_types

@google-cla
Copy link

google-cla bot commented Sep 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wangela
Copy link
Member

wangela commented Nov 7, 2023

Thank you for updating the place types, @GuyKachur!

@wangela wangela merged commit 4b62b97 into googlemaps:master Nov 7, 2023
5 checks passed
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants