fix: should round off timestamp #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuramoto
approved these changes
Jul 29, 2022
|
Thanks for the PR @hiddestokvis! |
googlemaps-bot
added a commit
that referenced
this pull request
Jul 29, 2022
### [3.3.19](v3.3.18...v3.3.19) (2022-07-29) ### Bug Fixes * should round off timestamp ([#835](#835)) ([002812e](002812e))
BaljeetSinghaw
added a commit
to BaljeetSinghaw/services-js
that referenced
this pull request
Nov 11, 2022
### [3.3.19](googlemaps/google-maps-services-js@v3.3.18...v3.3.19) (2022-07-29) ### Bug Fixes * should round off timestamp ([#835](googlemaps/google-maps-services-js#835)) ([7d592dd](googlemaps/google-maps-services-js@7d592dd))
Smile4192
added a commit
to Smile4192/google-maps-service-js
that referenced
this pull request
Mar 7, 2023
### [3.3.19](googlemaps/google-maps-services-js@v3.3.18...v3.3.19) (2022-07-29) ### Bug Fixes * should round off timestamp ([#835](googlemaps/google-maps-services-js#835)) ([002812e](googlemaps/google-maps-services-js@002812e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug where a date value converted to seconds, will most likely have decimal points. Something the API does not seem to accept.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #834 馃