Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PlaceType1 to match official documentation #882

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Update PlaceType1 to match official documentation #882

merged 1 commit into from
Nov 9, 2022

Conversation

r1sim
Copy link
Contributor

@r1sim r1sim commented Nov 4, 2022

I noticed that PlaceType1 does not contain all place types listed on the official documentation: https://developers.google.com/maps/documentation/places/web-service/supported_types#table1

This change adds the missing types drugstore, light_rail_station & university.

@google-cla
Copy link

google-cla bot commented Nov 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wangela
Copy link
Member

wangela commented Nov 9, 2022

Thanks for your contribution! I noticed primary_school is also missing; will open an issue and fix in a future PR.
Acknowledging that tests are failing due to Axios dependency, overriding that check.

@wangela wangela merged commit 0f6fcd4 into googlemaps:master Nov 9, 2022
@wangela wangela mentioned this pull request Nov 9, 2022
Open
googlemaps-bot added a commit that referenced this pull request Nov 17, 2022
@googlemaps-bot
chore(release): 3.3.24 [skip ci]
a6845aa 
### [3.3.24](v3.3.23...v3.3.24) (2022-11-17)

### Bug Fixes

* add `drugstore`, `light_rail_station` & `university` to `PlaceType1` ([#882](#882)) ([0f6fcd4](0f6fcd4))
* revert axios deps ([#889](#889)) ([b4dc304](b4dc304))
* update expected fields in place details test ([#890](#890)) ([3dc3439](3dc3439))

### Build System

* **deps-dev:** bump @types/node from 18.11.0 to 18.11.4 ([#876](#876)) ([a67b376](a67b376))
* **deps-dev:** bump @types/node from 18.11.4 to 18.11.8 ([#879](#879)) ([2702919](2702919))
* **deps-dev:** bump @types/node from 18.11.8 to 18.11.9 ([#883](#883)) ([c68d63f](c68d63f))
* **deps-dev:** bump @types/node from 18.8.1 to 18.8.4 ([#873](#873)) ([1a127ac](1a127ac))
* **deps-dev:** bump @types/node from 18.8.4 to 18.11.0 ([#874](#874)) ([11fa702](11fa702))
* **deps-dev:** bump typedoc from 0.23.15 to 0.23.16 ([#872](#872)) ([8074a9b](8074a9b))
* **deps-dev:** bump typedoc from 0.23.16 to 0.23.18 ([#877](#877)) ([5b77002](5b77002))
* **deps-dev:** bump typedoc from 0.23.18 to 0.23.19 ([#880](#880)) ([22d8718](22d8718))
* **deps-dev:** bump typedoc from 0.23.19 to 0.23.20 ([#884](#884)) ([3879549](3879549))
* **deps-dev:** bump typedoc from 0.23.20 to 0.23.21 ([#888](#888)) ([c4197af](c4197af))
* **deps:** bump @googlemaps/url-signature from 1.0.27 to 1.0.28 ([#887](#887)) ([ac0f628](ac0f628))
* **deps:** bump axios from 0.27.2 to 1.1.2 ([#871](#871)) ([9672e71](9672e71))
* **deps:** bump axios from 1.1.2 to 1.1.3 ([#875](#875)) ([033b013](033b013))
* **deps:** bump retry-axios from 2.6.0 to 3.0.0 ([#805](#805)) ([6036b25](6036b25))
Smile4192 added a commit to Smile4192/google-maps-service-js that referenced this pull request Mar 7, 2023
@Smile4192
chore(release): 3.3.24 [skip ci]
3fe8a9e 
### [3.3.24](googlemaps/google-maps-services-js@v3.3.23...v3.3.24) (2022-11-17)

### Bug Fixes

* add `drugstore`, `light_rail_station` & `university` to `PlaceType1` ([#882](googlemaps/google-maps-services-js#882)) ([0f6fcd4](googlemaps/google-maps-services-js@0f6fcd4))
* revert axios deps ([#889](googlemaps/google-maps-services-js#889)) ([b4dc304](googlemaps/google-maps-services-js@b4dc304))
* update expected fields in place details test ([#890](googlemaps/google-maps-services-js#890)) ([3dc3439](googlemaps/google-maps-services-js@3dc3439))

### Build System

* **deps-dev:** bump @types/node from 18.11.0 to 18.11.4 ([#876](googlemaps/google-maps-services-js#876)) ([a67b376](googlemaps/google-maps-services-js@a67b376))
* **deps-dev:** bump @types/node from 18.11.4 to 18.11.8 ([#879](googlemaps/google-maps-services-js#879)) ([2702919](googlemaps/google-maps-services-js@2702919))
* **deps-dev:** bump @types/node from 18.11.8 to 18.11.9 ([#883](googlemaps/google-maps-services-js#883)) ([c68d63f](googlemaps/google-maps-services-js@c68d63f))
* **deps-dev:** bump @types/node from 18.8.1 to 18.8.4 ([#873](googlemaps/google-maps-services-js#873)) ([1a127ac](googlemaps/google-maps-services-js@1a127ac))
* **deps-dev:** bump @types/node from 18.8.4 to 18.11.0 ([#874](googlemaps/google-maps-services-js#874)) ([11fa702](googlemaps/google-maps-services-js@11fa702))
* **deps-dev:** bump typedoc from 0.23.15 to 0.23.16 ([#872](googlemaps/google-maps-services-js#872)) ([8074a9b](googlemaps/google-maps-services-js@8074a9b))
* **deps-dev:** bump typedoc from 0.23.16 to 0.23.18 ([#877](googlemaps/google-maps-services-js#877)) ([5b77002](googlemaps/google-maps-services-js@5b77002))
* **deps-dev:** bump typedoc from 0.23.18 to 0.23.19 ([#880](googlemaps/google-maps-services-js#880)) ([22d8718](googlemaps/google-maps-services-js@22d8718))
* **deps-dev:** bump typedoc from 0.23.19 to 0.23.20 ([#884](googlemaps/google-maps-services-js#884)) ([3879549](googlemaps/google-maps-services-js@3879549))
* **deps-dev:** bump typedoc from 0.23.20 to 0.23.21 ([#888](googlemaps/google-maps-services-js#888)) ([c4197af](googlemaps/google-maps-services-js@c4197af))
* **deps:** bump @googlemaps/url-signature from 1.0.27 to 1.0.28 ([#887](googlemaps/google-maps-services-js#887)) ([ac0f628](googlemaps/google-maps-services-js@ac0f628))
* **deps:** bump axios from 0.27.2 to 1.1.2 ([#871](googlemaps/google-maps-services-js#871)) ([9672e71](googlemaps/google-maps-services-js@9672e71))
* **deps:** bump axios from 1.1.2 to 1.1.3 ([#875](googlemaps/google-maps-services-js#875)) ([033b013](googlemaps/google-maps-services-js@033b013))
* **deps:** bump retry-axios from 2.6.0 to 3.0.0 ([#805](googlemaps/google-maps-services-js#805)) ([6036b25](googlemaps/google-maps-services-js@6036b25))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r1sim @wangela