Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid algo zoom #368

Merged
merged 6 commits into from
Aug 2, 2022
Merged

Fix grid algo zoom #368

merged 6 commits into from
Aug 2, 2022

Conversation

mbv
Copy link
Contributor

@mbv mbv commented Jun 15, 2022

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #300 🦕

mbv added 2 commits June 15, 2022 09:17
 * grid algo continue display clustered marker after reaching max zoom
@google-cla
Copy link

google-cla bot commented Jun 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@amuramoto amuramoto merged commit abcefdf into googlemaps:main Aug 2, 2022
@amuramoto
Copy link
Member

Thanks for the PR @mbv!

github-actions bot pushed a commit that referenced this pull request Aug 2, 2022
* Fixed bug with grid algo on max zoom

 * grid algo continue display clustered marker after reaching max zoom

* Added tests for grid algo after reaching max zoom

* removed GridAlgorithm.filterMarkersToPaddedViewport

* removes map projection mocking from grid algo test

* fix linter errors abcefdf
googlemaps-bot pushed a commit that referenced this pull request Aug 2, 2022
### [2.0.10](v2.0.9...v2.0.10) (2022-08-02)

### Bug Fixes

* GridAlgorithm respects maxZoom ([#368](#368)) ([abcefdf](abcefdf))

### Miscellaneous Chores

* **deps-dev:** bump @babel/preset-env from 7.18.2 to 7.18.6 ([#386](#386)) ([1a62289](1a62289))
* **deps-dev:** bump @babel/preset-env from 7.18.6 to 7.18.9 ([#395](#395)) ([4c0d87d](4c0d87d))
* **deps-dev:** bump @babel/preset-env from 7.18.9 to 7.18.10 ([#403](#403)) ([07e5034](07e5034))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.18.6 to 7.18.9 ([#396](#396)) ([e3c685a](e3c685a))
* **deps-dev:** bump @rollup/plugin-typescript from 8.3.3 to 8.3.4 ([#407](#407)) ([f08b24b](f08b24b))
* **deps-dev:** bump core-js from 3.23.3 to 3.23.4 ([#391](#391)) ([fd5bab8](fd5bab8))
* **deps-dev:** bump core-js from 3.23.4 to 3.24.0 ([#400](#400)) ([8e4b9fe](8e4b9fe))
* **deps-dev:** bump core-js from 3.24.0 to 3.24.1 ([#404](#404)) ([40e1b83](40e1b83))
* **deps-dev:** bump eslint-plugin-jest from 26.5.3 to 26.6.0 ([#397](#397)) ([64d6df0](64d6df0))
* **deps-dev:** bump eslint-plugin-jest from 26.6.0 to 26.7.0 ([#405](#405)) ([45bbc94](45bbc94))
* **deps-dev:** bump eslint-plugin-prettier from 4.1.0 to 4.2.1 ([#388](#388)) ([5c80e85](5c80e85))
* **deps-dev:** bump geckodriver from 3.0.1 to 3.0.2 ([#389](#389)) ([33ec5a9](33ec5a9))
* **deps-dev:** bump rollup from 2.75.7 to 2.76.0 ([#390](#390)) ([c8eb563](c8eb563))
* **deps-dev:** bump rollup from 2.76.0 to 2.77.0 ([#394](#394)) ([10b59f7](10b59f7))
* **deps-dev:** bump rollup from 2.77.0 to 2.77.2 ([#402](#402)) ([a3258a3](a3258a3))
* **deps-dev:** bump typedoc from 0.23.1 to 0.23.5 ([#387](#387)) ([01d9f56](01d9f56))
* **deps-dev:** bump typedoc from 0.23.5 to 0.23.7 ([#392](#392)) ([2f1edd0](2f1edd0))
* **deps-dev:** bump typedoc from 0.23.7 to 0.23.9 ([#401](#401)) ([032591d](032591d))
* **deps-dev:** bump typedoc from 0.23.9 to 0.23.10 ([#406](#406)) ([6b2961e](6b2961e))
* **deps:** bump terser from 5.3.1 to 5.14.2 ([#399](#399)) ([161b943](161b943))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridAlgorithm keeps displaying cluster at maximum zoom level
3 participants