Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release adv markers support #616

Merged
merged 19 commits into from
May 17, 2023
Merged

feat: release adv markers support #616

merged 19 commits into from
May 17, 2023

Conversation

amuramoto
Copy link
Member

  • Implements cluster icons as AdvancedMarkerView instances when available

  • Adds marker utils to branch Marker and Adv Marker function calls

  • Adds Marker union type in global and implements

amuramoto and others added 19 commits April 24, 2023 12:59
* feat: Implements cluster icons as AdvancedMarkerView instances when available

* Adds marker utils to branch Marker and Adv Marker function calls

* Adds Marker union type in global and implements
## [2.1.0-beta.1](googlemaps/js-markerclusterer@v2.0.15...v2.1.0-beta.1) (2023-04-24)

### Features

* Adds Advanced Markers support ([googlemaps#592](googlemaps#592)) ([6dc246f](googlemaps@6dc246f))
* releases beta of advanced markers support ([4cf504c](googlemaps@4cf504c))
* trigger initial beta release of adv markers support ([googlemaps#596](googlemaps#596)) ([2b69f29](googlemaps@2b69f29))

### Miscellaneous Chores

* adds missing license header ([f37ac6e](googlemaps@f37ac6e))
* **deps-dev:** bump @babel/preset-env from 7.20.2 to 7.21.4 ([googlemaps#583](googlemaps#583)) ([1d27272](googlemaps@1d27272))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.20.13 to 7.21.0 ([googlemaps#555](googlemaps#555)) ([822ee6b](googlemaps@822ee6b))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.20.7 to 7.20.13 ([googlemaps#542](googlemaps#542)) ([0622a48](googlemaps@0622a48))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.10.0 to 2.16.1 ([googlemaps#566](googlemaps#566)) ([488e7a8](googlemaps@488e7a8))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.7.5 to 2.9.0 ([googlemaps#548](googlemaps#548)) ([ea182d8](googlemaps@ea182d8))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.9.0 to 2.10.0 ([googlemaps#563](googlemaps#563)) ([f8703f4](googlemaps@f8703f4))
* **deps-dev:** bump @rollup/plugin-commonjs from 24.0.0 to 24.0.1 ([googlemaps#538](googlemaps#538)) ([6a72469](googlemaps@6a72469))
* **deps-dev:** bump @rollup/plugin-commonjs from 24.0.1 to 24.1.0 ([googlemaps#590](googlemaps#590)) ([39d17dd](googlemaps@39d17dd))
* **deps-dev:** bump @rollup/plugin-html from 1.0.1 to 1.0.2 ([googlemaps#539](googlemaps#539)) ([7a6f6be](googlemaps@7a6f6be))
* **deps-dev:** bump @rollup/plugin-node-resolve from 15.0.1 to 15.0.2 ([googlemaps#586](googlemaps#586)) ([f4b8d96](googlemaps@f4b8d96))
* **deps-dev:** bump @rollup/plugin-typescript from 10.0.1 to 11.0.0 ([googlemaps#528](googlemaps#528)) ([1153860](googlemaps@1153860))
* **deps-dev:** bump @rollup/plugin-typescript from 11.0.0 to 11.1.0 ([googlemaps#584](googlemaps#584)) ([1e4fda4](googlemaps@1e4fda4))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.10 to 4.1.11 ([googlemaps#553](googlemaps#553)) ([263cd6f](googlemaps@263cd6f))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.11 to 4.1.12 ([googlemaps#562](googlemaps#562)) ([6c2e071](googlemaps@6c2e071))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.12 to 4.1.13 ([googlemaps#564](googlemaps#564)) ([ea6c9af](googlemaps@ea6c9af))
* **deps-dev:** bump chromedriver from 108.0.0 to 109.0.0 ([googlemaps#534](googlemaps#534)) ([5e2f93f](googlemaps@5e2f93f))
* **deps-dev:** bump chromedriver from 109.0.0 to 110.0.0 ([googlemaps#552](googlemaps#552)) ([7bdafb2](googlemaps@7bdafb2))
* **deps-dev:** bump chromedriver from 110.0.0 to 111.0.0 ([googlemaps#568](googlemaps#568)) ([c7507dc](googlemaps@c7507dc))
* **deps-dev:** bump chromedriver from 111.0.0 to 112.0.0 ([googlemaps#588](googlemaps#588)) ([c0ff346](googlemaps@c0ff346))
* **deps-dev:** bump core-js from 3.27.1 to 3.27.2 ([googlemaps#540](googlemaps#540)) ([da2359c](googlemaps@da2359c))
* **deps-dev:** bump core-js from 3.27.2 to 3.28.0 ([googlemaps#551](googlemaps#551)) ([a4f08a8](googlemaps@a4f08a8))
* **deps-dev:** bump core-js from 3.28.0 to 3.29.0 ([googlemaps#558](googlemaps#558)) ([35d368f](googlemaps@35d368f))
* **deps-dev:** bump core-js from 3.29.0 to 3.29.1 ([googlemaps#567](googlemaps#567)) ([646866b](googlemaps@646866b))
* **deps-dev:** bump core-js from 3.29.1 to 3.30.0 ([googlemaps#582](googlemaps#582)) ([a9f3b00](googlemaps@a9f3b00))
* **deps-dev:** bump core-js from 3.30.0 to 3.30.1 ([googlemaps#591](googlemaps#591)) ([3c4c695](googlemaps@3c4c695))
* **deps-dev:** bump eslint-config-prettier from 8.6.0 to 8.7.0 ([googlemaps#560](googlemaps#560)) ([cab209c](googlemaps@cab209c))
* **deps-dev:** bump eslint-config-prettier from 8.7.0 to 8.8.0 ([googlemaps#572](googlemaps#572)) ([06efb61](googlemaps@06efb61))
* **deps-dev:** bump eslint-plugin-jest from 27.2.0 to 27.2.1 ([googlemaps#530](googlemaps#530)) ([65da8cc](googlemaps@65da8cc))
* **deps-dev:** bump prettier from 2.8.1 to 2.8.2 ([googlemaps#529](googlemaps#529)) ([c259039](googlemaps@c259039))
* **deps-dev:** bump prettier from 2.8.2 to 2.8.3 ([googlemaps#535](googlemaps#535)) ([2afc849](googlemaps@2afc849))
* **deps-dev:** bump prettier from 2.8.3 to 2.8.4 ([googlemaps#550](googlemaps#550)) ([df71dbe](googlemaps@df71dbe))
* **deps-dev:** bump prettier from 2.8.4 to 2.8.5 ([googlemaps#575](googlemaps#575)) ([f6c34be](googlemaps@f6c34be))
* **deps-dev:** bump prettier from 2.8.5 to 2.8.7 ([googlemaps#579](googlemaps#579)) ([68f10c5](googlemaps@68f10c5))
* **deps-dev:** bump selenium-webdriver from 4.7.1 to 4.8.0 ([googlemaps#541](googlemaps#541)) ([09701f7](googlemaps@09701f7))
* **deps-dev:** bump selenium-webdriver from 4.8.0 to 4.8.1 ([googlemaps#554](googlemaps#554)) ([0ac9337](googlemaps@0ac9337))
* **deps-dev:** bump selenium-webdriver from 4.8.1 to 4.8.2 ([googlemaps#578](googlemaps#578)) ([5f788ca](googlemaps@5f788ca))
* **deps-dev:** bump typedoc from 0.23.23 to 0.23.24 ([googlemaps#527](googlemaps#527)) ([27333bc](googlemaps@27333bc))
* **deps-dev:** bump typedoc from 0.23.24 to 0.23.25 ([googlemaps#549](googlemaps#549)) ([8e757d0](googlemaps@8e757d0))
* **deps-dev:** bump typedoc from 0.23.25 to 0.23.26 ([googlemaps#559](googlemaps#559)) ([1e17eb6](googlemaps@1e17eb6))
* **deps-dev:** bump typedoc from 0.23.26 to 0.23.28 ([googlemaps#573](googlemaps#573)) ([bd532a4](googlemaps@bd532a4))
* **deps-dev:** bump typedoc from 0.23.28 to 0.24.1 ([googlemaps#585](googlemaps#585)) ([126b35a](googlemaps@126b35a))
* **deps-dev:** bump typedoc from 0.24.1 to 0.24.4 ([googlemaps#589](googlemaps#589)) ([5efe650](googlemaps@5efe650))
* **deps-dev:** bump typescript from 4.9.4 to 4.9.5 ([googlemaps#547](googlemaps#547)) ([679de16](googlemaps@679de16))
* **deps:** bump http-cache-semantics from 4.1.0 to 4.1.1 ([googlemaps#544](googlemaps#544)) ([4ef18ed](googlemaps@4ef18ed))
* **deps:** bump json5 from 2.1.3 to 2.2.3 ([googlemaps#526](googlemaps#526)) ([49ad6e1](googlemaps@49ad6e1))
## [2.1.0-beta.2](googlemaps/js-markerclusterer@v2.1.0-beta.1...v2.1.0-beta.2) (2023-05-08)

### Features

* trigger beta release ([c9fc07a](googlemaps@c9fc07a))

### Code Refactoring

* migrates 'View' classes to 'Element' ([googlemaps#608](googlemaps#608)) ([23a538e](googlemaps@23a538e))
@amuramoto amuramoto requested a review from a team as a code owner May 17, 2023 22:51
@amuramoto amuramoto requested a review from mpegg21 May 17, 2023 22:51
@google-cla
Copy link

google-cla bot commented May 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@amuramoto amuramoto merged commit cb2fa9f into googlemaps:main May 17, 2023
15 of 16 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2023
* feat: Adds Advanced Markers support (#592)

* feat: Implements cluster icons as AdvancedMarkerView instances when available

* Adds marker utils to branch Marker and Adv Marker function calls

* Adds Marker union type in global and implements cb2fa9f
googlemaps-bot pushed a commit that referenced this pull request May 17, 2023
## [2.1.0](v2.0.15...v2.1.0) (2023-05-17)

### Features

* releases adv markers support ([#616](#616)) ([cb2fa9f](cb2fa9f)), closes [#592](#592)

### Bug Fixes

* Added algorithmOptions to MarkerClusterer constr. ([#537](#537)) ([420ee42](420ee42))

### Miscellaneous Chores

* adds beta branch semantic release ([#594](#594)) ([767f756](767f756))
* **deps-dev:** bump @babel/preset-env from 7.20.2 to 7.21.4 ([#583](#583)) ([1d27272](1d27272))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.20.13 to 7.21.0 ([#555](#555)) ([822ee6b](822ee6b))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.20.7 to 7.20.13 ([#542](#542)) ([0622a48](0622a48))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.10.0 to 2.16.1 ([#566](#566)) ([488e7a8](488e7a8))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.7.5 to 2.9.0 ([#548](#548)) ([ea182d8](ea182d8))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.9.0 to 2.10.0 ([#563](#563)) ([f8703f4](f8703f4))
* **deps-dev:** bump @rollup/plugin-commonjs from 24.0.0 to 24.0.1 ([#538](#538)) ([6a72469](6a72469))
* **deps-dev:** bump @rollup/plugin-commonjs from 24.0.1 to 24.1.0 ([#590](#590)) ([39d17dd](39d17dd))
* **deps-dev:** bump @rollup/plugin-html from 1.0.1 to 1.0.2 ([#539](#539)) ([7a6f6be](7a6f6be))
* **deps-dev:** bump @rollup/plugin-node-resolve from 15.0.1 to 15.0.2 ([#586](#586)) ([f4b8d96](f4b8d96))
* **deps-dev:** bump @rollup/plugin-typescript from 10.0.1 to 11.0.0 ([#528](#528)) ([1153860](1153860))
* **deps-dev:** bump @rollup/plugin-typescript from 11.0.0 to 11.1.0 ([#584](#584)) ([1e4fda4](1e4fda4))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.10 to 4.1.11 ([#553](#553)) ([263cd6f](263cd6f))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.11 to 4.1.12 ([#562](#562)) ([6c2e071](6c2e071))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.12 to 4.1.13 ([#564](#564)) ([ea6c9af](ea6c9af))
* **deps-dev:** bump chromedriver from 108.0.0 to 109.0.0 ([#534](#534)) ([5e2f93f](5e2f93f))
* **deps-dev:** bump chromedriver from 109.0.0 to 110.0.0 ([#552](#552)) ([7bdafb2](7bdafb2))
* **deps-dev:** bump chromedriver from 110.0.0 to 111.0.0 ([#568](#568)) ([c7507dc](c7507dc))
* **deps-dev:** bump chromedriver from 111.0.0 to 112.0.0 ([#588](#588)) ([c0ff346](c0ff346))
* **deps-dev:** bump core-js from 3.27.1 to 3.27.2 ([#540](#540)) ([da2359c](da2359c))
* **deps-dev:** bump core-js from 3.27.2 to 3.28.0 ([#551](#551)) ([a4f08a8](a4f08a8))
* **deps-dev:** bump core-js from 3.28.0 to 3.29.0 ([#558](#558)) ([35d368f](35d368f))
* **deps-dev:** bump core-js from 3.29.0 to 3.29.1 ([#567](#567)) ([646866b](646866b))
* **deps-dev:** bump core-js from 3.29.1 to 3.30.0 ([#582](#582)) ([a9f3b00](a9f3b00))
* **deps-dev:** bump core-js from 3.30.0 to 3.30.1 ([#591](#591)) ([3c4c695](3c4c695))
* **deps-dev:** bump eslint-config-prettier from 8.6.0 to 8.7.0 ([#560](#560)) ([cab209c](cab209c))
* **deps-dev:** bump eslint-config-prettier from 8.7.0 to 8.8.0 ([#572](#572)) ([06efb61](06efb61))
* **deps-dev:** bump eslint-plugin-jest from 27.2.0 to 27.2.1 ([#530](#530)) ([65da8cc](65da8cc))
* **deps-dev:** bump prettier from 2.8.1 to 2.8.2 ([#529](#529)) ([c259039](c259039))
* **deps-dev:** bump prettier from 2.8.2 to 2.8.3 ([#535](#535)) ([2afc849](2afc849))
* **deps-dev:** bump prettier from 2.8.3 to 2.8.4 ([#550](#550)) ([df71dbe](df71dbe))
* **deps-dev:** bump prettier from 2.8.4 to 2.8.5 ([#575](#575)) ([f6c34be](f6c34be))
* **deps-dev:** bump prettier from 2.8.5 to 2.8.7 ([#579](#579)) ([68f10c5](68f10c5))
* **deps-dev:** bump prettier from 2.8.7 to 2.8.8 ([#598](#598)) ([4a82109](4a82109))
* **deps-dev:** bump selenium-webdriver from 4.7.1 to 4.8.0 ([#541](#541)) ([09701f7](09701f7))
* **deps-dev:** bump selenium-webdriver from 4.8.0 to 4.8.1 ([#554](#554)) ([0ac9337](0ac9337))
* **deps-dev:** bump selenium-webdriver from 4.8.1 to 4.8.2 ([#578](#578)) ([5f788ca](5f788ca))
* **deps-dev:** bump selenium-webdriver from 4.8.2 to 4.9.0 ([#599](#599)) ([5e60e57](5e60e57))
* **deps-dev:** bump typedoc from 0.23.23 to 0.23.24 ([#527](#527)) ([27333bc](27333bc))
* **deps-dev:** bump typedoc from 0.23.24 to 0.23.25 ([#549](#549)) ([8e757d0](8e757d0))
* **deps-dev:** bump typedoc from 0.23.25 to 0.23.26 ([#559](#559)) ([1e17eb6](1e17eb6))
* **deps-dev:** bump typedoc from 0.23.26 to 0.23.28 ([#573](#573)) ([bd532a4](bd532a4))
* **deps-dev:** bump typedoc from 0.23.28 to 0.24.1 ([#585](#585)) ([126b35a](126b35a))
* **deps-dev:** bump typedoc from 0.24.1 to 0.24.4 ([#589](#589)) ([5efe650](5efe650))
* **deps-dev:** bump typedoc from 0.24.4 to 0.24.6 ([#597](#597)) ([835b3ad](835b3ad))
* **deps-dev:** bump typescript from 4.9.4 to 4.9.5 ([#547](#547)) ([679de16](679de16))
* **deps:** bump http-cache-semantics from 4.1.0 to 4.1.1 ([#544](#544)) ([4ef18ed](4ef18ed))
* **deps:** bump json5 from 2.1.3 to 2.2.3 ([#526](#526)) ([49ad6e1](49ad6e1))
* **deps:** bump supercluster from 7.1.5 to 8.0.1 ([#602](#602)) ([40b123a](40b123a))
* revert version changes in releease.yml ([265d7cf](265d7cf))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hkaiser
Copy link

hkaiser commented May 18, 2023

FWIW, this change breaks existing gmaps applications that use the 'legacy bootstrap' script tag to load the google maps script:

<script src="https://maps.googleapis.com/maps/api/js?key=YOUR_API_KEY&libraries=marker&callback=initMap"></script>

complaining about undefined symbol google.maps.marker.

@amuramoto
Copy link
Member Author

@hkaiser This should be resolved in v2.1.2. See #617

@hkaiser
Copy link

hkaiser commented May 18, 2023

@hkaiser This should be resolved in v2.1.2. See #617

@amuramoto I can confirm that the issue was fixed in v2.1.2. Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants