Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce flickering #699

Merged
merged 6 commits into from
Jul 13, 2023
Merged

fix: reduce flickering #699

merged 6 commits into from
Jul 13, 2023

Conversation

amuramoto
Copy link
Member

Merges #660 into main

semantic-release-bot and others added 4 commits June 1, 2023 17:46
## [2.2.0-beta.1](v2.1.4...v2.2.0-beta.1) (2023-06-01)

### Features

* add a dev server ([#656](#656)) ([b025dec](b025dec))

### Code Refactoring

* **distanceBetweenPoints:** optimize ([#646](#646)) ([e0f9a11](e0f9a11))

### Miscellaneous Chores

* **deps-dev:** bump @babel/preset-env from 7.21.5 to 7.22.4 ([#650](#650)) ([982730d](982730d))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.21.5 to 7.22.3 ([#649](#649)) ([1c9f4fb](1c9f4fb))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.14 to 4.1.15 ([#655](#655)) ([526e65c](526e65c))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#654](#654)) ([68a94db](68a94db))
* **deps-dev:** bump @typescript-eslint/parser from 5.59.7 to 5.59.8 ([#653](#653)) ([a46d0a7](a46d0a7))
* **deps-dev:** bump geckodriver from 4.0.0 to 4.0.2 ([#652](#652)) ([19518a4](19518a4))
* update actions to use Node.js 16 ([#659](#659)) ([bcbdddf](bcbdddf))
* chore(release): 2.2.0 [skip ci]

## [2.2.0](v2.1.4...v2.2.0) (2023-06-01)

### Features

* add a dev server ([#656](#656)) ([b025dec](b025dec))

### Code Refactoring

* **distanceBetweenPoints:** optimize ([#646](#646)) ([e0f9a11](e0f9a11))

### Miscellaneous Chores

* **deps-dev:** bump @babel/preset-env from 7.21.5 to 7.22.4 ([#650](#650)) ([982730d](982730d))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.21.5 to 7.22.3 ([#649](#649)) ([1c9f4fb](1c9f4fb))
* **deps-dev:** bump @types/selenium-webdriver from 4.1.14 to 4.1.15 ([#655](#655)) ([526e65c](526e65c))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#654](#654)) ([68a94db](68a94db))
* **deps-dev:** bump @typescript-eslint/parser from 5.59.7 to 5.59.8 ([#653](#653)) ([a46d0a7](a46d0a7))
* **deps-dev:** bump geckodriver from 4.0.0 to 4.0.2 ([#652](#652)) ([19518a4](19518a4))
* update actions to use Node.js 16 ([#659](#659)) ([bcbdddf](bcbdddf))

* fix: reduce flickering

* Individual markers

Before this PR all the individual markers were removed from the map during the render cycle
by calling the reset method and to maybe be added back later in renderClusters.

After this CL the individual markers that will still be displayed on the map after the
render cycle are not removed from the map.

* Group markers

This PR still renders the group markers each time but the former group markers are only
removed from the map after the new one are added.

It turns out that removing the group markers in the next raf really help with flickering.

*  chore: resolves merge conflicts on to beta

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Alex Muramoto <amuramoto@apache.org>
## [2.2.0-beta.2](v2.2.0-beta.1...v2.2.0-beta.2) (2023-06-01)

### Bug Fixes

* reduce flickering ([#660](#660)) ([8b756a7](8b756a7)), closes [#656](#656) [#646](#646) [#650](#650) [#649](#649) [#655](#655) [#654](#654) [#653](#653) [#652](#652) [#659](#659)

### Miscellaneous Chores

* trigger beta release ([434cc68](434cc68))
@google-cla
Copy link

google-cla bot commented Jul 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

amuramoto and others added 2 commits July 13, 2023 09:35
### [2.3.2-beta.1](v2.3.1...v2.3.2-beta.1) (2023-07-13)

### Bug Fixes

* reduce flickering ([#660](#660)) ([8b756a7](8b756a7)), closes [#656](#656) [#646](#646) [#650](#650) [#649](#649) [#655](#655) [#654](#654) [#653](#653) [#652](#652) [#659](#659)

### Miscellaneous Chores

* **deps-dev:** bump @babel/preset-env from 7.22.4 to 7.22.5 ([#683](#683)) ([24f0a1c](24f0a1c))
* **deps-dev:** bump @babel/preset-env from 7.22.5 to 7.22.7 ([#694](#694)) ([2eee952](2eee952))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.22.3 to 7.22.6 ([#697](#697)) ([c8850f3](c8850f3))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.19.1 to 2.19.2 ([#684](#684)) ([d1aa925](d1aa925))
* **deps-dev:** bump @rollup/plugin-typescript from 11.1.1 to 11.1.2 ([#690](#690)) ([e5ba6c5](e5ba6c5))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#686](#686)) ([0e1f24a](0e1f24a))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#689](#689)) ([0becc85](0becc85))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#696](#696)) ([bebef45](bebef45))
* **deps-dev:** bump core-js from 3.31.0 to 3.31.1 ([#695](#695)) ([e865156](e865156))
* **deps-dev:** bump eslint from 8.42.0 to 8.43.0 ([#685](#685)) ([122eb7b](122eb7b))
* **deps-dev:** bump eslint from 8.43.0 to 8.44.0 ([#688](#688)) ([7f21c12](7f21c12))
* **deps:** bump tough-cookie from 4.1.2 to 4.1.3 ([#693](#693)) ([adf3051](adf3051))
* **release:** 2.2.0-beta.1 [skip ci] ([90a62ee](90a62ee)), closes [#656](#656) [#646](#646) [#650](#650) [#649](#649) [#655](#655) [#654](#654) [#653](#653) [#652](#652) [#659](#659)
* **release:** 2.2.0-beta.2 [skip ci] ([3706d68](3706d68)), closes [#656](#656) [#646](#646) [#650](#650) [#649](#649) [#655](#655) [#654](#654) [#653](#653) [#652](#652) [#659](#659)
* trigger beta release ([434cc68](434cc68))
@amuramoto amuramoto merged commit 12c1762 into main Jul 13, 2023
4 of 5 checks passed
@amuramoto amuramoto deleted the beta branch July 13, 2023 16:39
googlemaps-bot pushed a commit that referenced this pull request Jul 13, 2023
### [2.3.2](v2.3.1...v2.3.2) (2023-07-13)

### Bug Fixes

* reduce flickering ([#699](#699)) ([12c1762](12c1762)), closes [#656](#656) [#646](#646) [#650](#650) [#649](#649) [#655](#655) [#654](#654) [#653](#653) [#652](#652) [#659](#659) [#660](#660) [#656](#656) [#646](#646) [#650](#650) [#649](#649) [#655](#655) [#654](#654) [#653](#653) [#652](#652) [#659](#659)

### Miscellaneous Chores

* **deps-dev:** bump @babel/preset-env from 7.22.4 to 7.22.5 ([#683](#683)) ([24f0a1c](24f0a1c))
* **deps-dev:** bump @babel/preset-env from 7.22.5 to 7.22.7 ([#694](#694)) ([2eee952](2eee952))
* **deps-dev:** bump @babel/runtime-corejs3 from 7.22.3 to 7.22.6 ([#697](#697)) ([c8850f3](c8850f3))
* **deps-dev:** bump @googlemaps/jest-mocks from 2.19.1 to 2.19.2 ([#684](#684)) ([d1aa925](d1aa925))
* **deps-dev:** bump @rollup/plugin-typescript from 11.1.1 to 11.1.2 ([#690](#690)) ([e5ba6c5](e5ba6c5))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#686](#686)) ([0e1f24a](0e1f24a))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#689](#689)) ([0becc85](0becc85))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#696](#696)) ([bebef45](bebef45))
* **deps-dev:** bump core-js from 3.31.0 to 3.31.1 ([#695](#695)) ([e865156](e865156))
* **deps-dev:** bump eslint from 8.42.0 to 8.43.0 ([#685](#685)) ([122eb7b](122eb7b))
* **deps-dev:** bump eslint from 8.43.0 to 8.44.0 ([#688](#688)) ([7f21c12](7f21c12))
* **deps:** bump tough-cookie from 4.1.2 to 4.1.3 ([#693](#693)) ([adf3051](adf3051))
* manually trigger release action ([a9bf661](a9bf661))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants