Inner blocks

[sduverger]

Hi @felixwilhelm,

One of my colleagues discovered the following issue. When you uncomment the inner function blocks, you will observe an abnormal increasing number of matches:

• 1 bloc = 1 match
• 2 blocs = 657 matches
• 3 blocs = 3404 matches
• 4 blocs = 10446 matches

% cat test.pat
{
  _* $p = _;
  free($p);
  _;
  free($p);
}

% cat test.c
void double_free_multiple_blocks()
{
    {
	char *s = malloc(10);
	free(s);
	for (int i = 0; i < 10; i++) {
	    // do stuff
	}
	free(s);
    }
    {
	char *s = malloc(10);
	free(s);
	for (int i = 0; i < 10; i++) {
	    // do stuff
	}
	free(s);
    }
    //{
    //	char *s = malloc(10);
    //	free(s);
    //	for (int i = 0; i < 10; i++) {
    //	    // do stuff
    //	}
    //	free(s);
    //}
    //{
    //	char *s = malloc(10);
    //	free(s);
    //	for (int i = 0; i < 10; i++) {
    //	    // do stuff
    //	}
    //	free(s);
    //}
}

% weggli "$(<test.pat)" test.c | grep test.c | wc -l
   657

[felixwilhelm]

Nice catch. Matching of _; was too lax.
Should be fixed now :)

[sduverger]

Thanks for your active support ! 👍