Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Fix missing argument from build_query_tree #30

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

fabianfreyer
Copy link
Contributor

In 545bf4f (#23), a fourth argument to builder::build_query_tree was introduced, but not added to the python bindings.

Building with cargo build --features "python" fails with:

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
  --> src/python.rs:38:14
   |
38 |     let qt = crate::builder::build_query_tree(q, &mut c, false);
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -  ------  ----- supplied 3 arguments
   |              |
   |              expected 4 arguments
   |
note: function defined here
  --> src/builder.rs:28:8
   |
28 | pub fn build_query_tree(
   |        ^^^^^^^^^^^^^^^^
29 |     source: &str,
   |     ------------
30 |     cursor: &mut TreeCursor,
   |     -----------------------
31 |     is_cpp: bool,
   |     ------------
32 |     regex_constraints: Option<RegexMap>,
   |     -----------------------------------

For more information about this error, try `rustc --explain E0061`.
error: could not compile `weggli` due to previous error

This fixes the python build.

In 545bf4f (weggli-rs#23), a fourth argument to
`builder::build_query_tree` was introduced, but not added to the python
bindings.
@felixwilhelm felixwilhelm merged commit 3115f4e into weggli-rs:main Jan 27, 2022
@felixwilhelm
Copy link
Collaborator

Thanks! I should really add tests for the Python API

@fabianfreyer fabianfreyer deleted the python-build-query-tree branch January 27, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants