Skip to content

Commit

Permalink
Removing LifecycleRegistry reference from RepoFragment (#313)
Browse files Browse the repository at this point in the history
* Removing LifecycleRegistry reference from RepoFragment

* fixing link to readme also

* updating CI config

* Updating circle CI
  • Loading branch information
florina-muntenescu committed Feb 23, 2018
1 parent 330481a commit 1880a20
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 29 deletions.
Expand Up @@ -52,8 +52,6 @@ public class RepoFragment extends Fragment implements Injectable {

private static final String REPO_NAME_KEY = "repo_name";

private final LifecycleRegistry lifecycleRegistry = new LifecycleRegistry(this);

@Inject
ViewModelProvider.Factory viewModelFactory;

Expand All @@ -66,11 +64,6 @@ public class RepoFragment extends Fragment implements Injectable {
AutoClearedValue<RepoFragmentBinding> binding;
AutoClearedValue<ContributorAdapter> adapter;

@Override
public LifecycleRegistry getLifecycle() {
return lifecycleRegistry;
}

@Override
public void onActivityCreated(@Nullable Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
Expand Down
20 changes: 2 additions & 18 deletions GithubBrowserSample/gradle/wrapper/gradle-wrapper.properties
@@ -1,22 +1,6 @@
#
# Copyright (C) 2017 The Android Open Source Project
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

#Fri May 19 09:08:10 PDT 2017
#Thu Feb 22 10:53:38 GMT 2018
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -27,7 +27,7 @@ how to use ViewModels and Room together with RxJava, in Kotlin.
* **[PagingSample](https://github.com/googlesamples/android-architecture-components/tree/master/PagingSample)** - Shows
how to use the Paging library (preview) with Room, in Kotlin.

* **[PagingNetworkSample](https://github.com/googlesamples/android-architecture-components/tree/master/PagingNetworkSample)** - Shows
* **[PagingNetworkSample](https://github.com/googlesamples/android-architecture-components/tree/master/PagingWithNetworkSample)** - Shows
how to use the Paging library (preview) with a backend API via Retrofit, in Kotlin.

### Other Architecture Components Samples
Expand Down
2 changes: 1 addition & 1 deletion circle.yml
Expand Up @@ -7,7 +7,7 @@ machine:
dependencies:
pre:
- sudo pip install -U crcmod
- echo y | android update sdk --no-ui --all --filter "tools,platform-tools,build-tools-26.0.2,android-26,extra-android-m2repository"
- echo y | android update sdk --no-ui --all --filter "tools,platform-tools,build-tools-27.0.3,android-26,extra-android-m2repository"
- echo ${GCLOUD_SERVICE_KEY} | base64 --decode > ${HOME}/client-secret.json
- sudo /opt/google-cloud-sdk/bin/gcloud config set project android-devrel-ci
- sudo /opt/google-cloud-sdk/bin/gcloud --quiet components update
Expand Down
4 changes: 2 additions & 2 deletions versions.gradle
Expand Up @@ -21,7 +21,7 @@ versions.dexmaker = "2.2.0"
versions.constraint_layout = "1.0.2"
versions.glide = "3.8.0"
versions.timber = "4.5.1"
versions.android_gradle_plugin = "3.0.0"
versions.android_gradle_plugin = "3.0.1"
versions.rxjava2 = "2.1.3"
versions.rx_android = "2.0.1"
versions.atsl_runner = "1.0.1"
Expand Down Expand Up @@ -113,7 +113,7 @@ ext.deps = deps
def build_versions = [:]
build_versions.min_sdk = 14
build_versions.target_sdk = 26
build_versions.build_tools = "26.0.2"
build_versions.build_tools = "27.0.3"
ext.build_versions = build_versions


Expand Down

0 comments on commit 1880a20

Please sign in to comment.