New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypted/Secure Room with SafeRoom #218
Conversation
Lovely out of the box encryption supported from room natively would be great! |
Here is a Google issue for this too https://issuetracker.google.com/issues/112806418 |
5d3a4a6
to
2ce7517
Compare
Maven https://s3.amazonaws.com/repo.commonsware.com is not trust full, I run into serious issues with version So I made a fork with a deterministic build ! https://github.com/hannesa2/cwac-saferoom/pull/2 |
Maybe we could make this part of the wiki / README.md? |
Maven https://s3.amazonaws.com/repo.commonsware.com is not trust full, I run into serious isues with version 0.5.1, it migrates pragam aund version 1.0.0 reverted it. But code has nothing of this included, so it seams artifacts and code does not fit, and was build on a local machine So I made a fork with a deterministic build ! Who is interested in security should ask to whom you trust ! Public is better then private
I can not recommend https://github.com/commonsguy/cwac-saferoom for production. The company, I work for, removed this lib <= v1.0.1 because there were a lot of unexplainable, corrupted databases (with stable password) observed in Crashlytics. We were never able to reproduce it in development, so we decided to remove it. |
I don't know what the best approach is to force encryption for Room. So I create this PR to show the maintainer(s) of this repo how a possible way could look like, or to keep attention on encryption.
I know this is not merge-able, but maybe I help to force encryption for Room
To make it short: we want encryption for Room !