Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted/Secure Room with SafeRoom #218

Closed
wants to merge 3 commits into from

Conversation

hannesa2
Copy link

@hannesa2 hannesa2 commented Oct 26, 2017

I don't know what the best approach is to force encryption for Room. So I create this PR to show the maintainer(s) of this repo how a possible way could look like, or to keep attention on encryption.
I know this is not merge-able, but maybe I help to force encryption for Room

To make it short: we want encryption for Room !

@originx
Copy link

originx commented Oct 27, 2017

Lovely out of the box encryption supported from room natively would be great!

@hannesa2
Copy link
Author

Here is a Google issue for this too https://issuetracker.google.com/issues/112806418

@hannesa2 hannesa2 force-pushed the SafeRoom branch 2 times, most recently from 5d3a4a6 to 2ce7517 Compare October 1, 2018 06:20
@hannesa2 hannesa2 changed the title Secure Room with SafeRoom Encrypted/Secure Room with SafeRoom Feb 15, 2019
@hannesa2
Copy link
Author

hannesa2 commented Feb 15, 2019

Maven https://s3.amazonaws.com/repo.commonsware.com is not trust full, I run into serious issues with version 0.5.1, it migrates pragma and version 1.0.0 reverted it.
But code has nothing of this included, so it seems artefacts and code does not fit, and was build on a local machine

So I made a fork with a deterministic build !
Who is interested in security should ask to whom you trust ! Public is better then private

https://github.com/hannesa2/cwac-saferoom/pull/2
https://jitpack.io/#hannesa2/cwac-saferoom

@dazza5000
Copy link
Contributor

Maybe we could make this part of the wiki / README.md?

Maven https://s3.amazonaws.com/repo.commonsware.com is not trust full, I run into serious isues with version 0.5.1, it migrates pragam aund version 1.0.0 reverted it.
But code has nothing of this included, so it seams artifacts and code does not fit, and was build on a local machine

So I made a fork with a deterministic build !
Who is interested in security should ask to whom you trust ! Public is better then private
@hannesa2
Copy link
Author

I can not recommend https://github.com/commonsguy/cwac-saferoom for production. The company, I work for, removed this lib <= v1.0.1 because there were a lot of unexplainable, corrupted databases (with stable password) observed in Crashlytics.
Arrount 1 % of all sessions, it sounds not much, but when you have millions of installations, then it's too much !

We were never able to reproduce it in development, so we decided to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants