Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalan strings #496

Merged
merged 26 commits into from Oct 30, 2019
Merged

Add catalan strings #496

merged 26 commits into from Oct 30, 2019

Conversation

vmadalin
Copy link
Contributor

Description

Add support for the Catalan language as it was requested in #462

Copy link

@alorma alorma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i'm not an expert, some comments

app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
@vmadalin
Copy link
Contributor Author

Thanks to @franzeszpere, @javichaques and @alorma for your contribution helping this project to improve Catalan translations PR. I applied all of your suggestions :), please check if all are ok now.

@alorma
Copy link

alorma commented Oct 29, 2019

@vmadalin

Let me ping @Ereza as he knows better than me about Catalan translations

Copy link

@Ereza Ereza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several issues, I added suggestions for everything I think could be improved. The most common issue is that in Catalan, actions in buttons or menus must always be in imperative tense, not in infinitive (other languages like Spanish use infinitives instead, so this is a common error). For example, "Afegir" should be "Afegeix".

Oh, and thanks for translating it into Catalan! :P

app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ca/strings.xml Outdated Show resolved Hide resolved
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vmadalin and others added 7 commits October 29, 2019 22:47
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
@Ereza
Copy link

Ereza commented Oct 29, 2019

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vmadalin
Copy link
Contributor Author

@Ereza Thank you numerous contribution to improve Catalan translation for this sample project, I merge several of them having pending only two suggest changes to discuss more in detail.

vmadalin and others added 8 commits October 30, 2019 18:11
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
Co-Authored-By: Eduard Ereza Martínez <eduard@ereza.cat>
@vmadalin
Copy link
Contributor Author

@Ereza Thanks again for your contribution and time reviewing the translations 👏 . I update the PR with all the suggestions. Please review them and let's approve it for merge. Thank you all

Copy link

@Ereza Ereza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your time! :)

@tiembo
Copy link
Contributor

tiembo commented Oct 30, 2019

Thank you everyone for contributing to this translation! Added this to the list of translations on the Wiki.

@tiembo tiembo merged commit 0202dde into android:master Oct 30, 2019
@tiembo tiembo added this to the 2019-10 milestone Oct 30, 2019
@tiembo tiembo added the enhancement New feature or request label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants