Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcode for libprotobuf-lite.a and cardboard-xr-plugin/tree/master/Runtime/iOS/cardboard_api.a #84

Closed
HerotechDevs opened this issue Jul 28, 2020 · 8 comments
Labels
feature request New feature or request
Projects

Comments

@HerotechDevs
Copy link

HerotechDevs commented Jul 28, 2020

I am getting an error in XCode

"CardboardXrProvider.a does not contain bitcode"

Even if I disable bitcode in the project settings it keeps giving this error. what to do?
(If i disable bitcode for unity framework I get a lot of other errors)

@jballoffet jballoffet added the bug Something isn't working label Aug 28, 2020
@jballoffet
Copy link
Member

This issue should be solved on v1.2.0 (to be released very soon) as we have merged both the SDK and XR Provider into one single library (.a). Furthermore, release v1.2.0 also will include the XR Provider source code, which makes it possible for you to rebuild the binaries from source as needed to enable bitcode. Bear in mind that you will need to rebuild the protobuf library as well (see: https://developers.google.com/cardboard/develop/ios/protobuf).

@chaosemer
Copy link
Contributor

With 1.2.0 out, you can now compile the library yourself.

@chaosemer chaosemer added feature request New feature or request and removed bug Something isn't working labels Sep 1, 2020
@joker-gizmo
Copy link

Any news about 1.2.0?

@whizzkid
Copy link

whizzkid commented Sep 1, 2020

It was released 7 hours ago. check the main project page :)

@agalbachicar-gg agalbachicar-gg changed the title No bitcode support Use bitcode for libprotobuf-lite.a and cardboard-xr-plugin/tree/master/Runtime/iOS/cardboard_api.a Nov 17, 2020
@kafumanto
Copy link

Hi!

Following from issue #184, under iOS we would need cardboard_api.a to be able to compile with ENABLE_BITCODE enabled out-of-the-box. This is the normal configuration expected by Apple for release on the App Store.

To support this, the pre-compiled libprotobuf-lite.a for iOS should be provided with ENABLE_BITCODE enabled.

While it's not a problem for cardboard_api.a (as it's be compiled from this project), re-compiling libprotobuf-lite.a is more involved as it requires to install other external tools. As support for iOS is part of the core library, I think it would be better to provide the proper setup right out-of-the-box.

From this bug report, it's not clear (to me) if you plan to provide this pre-compiled library with ENABLE_BITCODE enabled or if this is leaved to us to re-compile it. (well.. as the bug is still open, maybe you plan to fix it... but I would like to be sure what the plan is :) )

Thanks.

@jballoffet
Copy link
Member

Sorry for the long delay here, @kafumanto. The right solution for this would be avoiding the need to use a protobuf prebuilt binary and instead adding Protobuf C++ as a dependency in the Xcode project. This would allow the user to enable or not bitcode according to their needs.

@jballoffet
Copy link
Member

A fix for this has been submitted and it will be included in v1.9.0. Thanks for reaching out!

@xinyunh0929
Copy link
Contributor

Feature added in 1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Development

No branches or pull requests

7 participants