Name conversions and component modularity

[mbykovskyy]

I need an autocomplete component so I was thinking about pulling @bamnet's work and add on to it, but I'm curious about your conventions. Do you prefer keeping components in files that reflect Google Maps API namespaces such as google-map.html and google-map-places.html? Or is it good practice to separate components into their own files i.e. google-map.html, google-map-marker.html, google-places-autocomplete.html?

[bamnet]

I think it's useful to make distinct features, like autocomplete, into their own component files. Developers might want to pull in the autocomplete box without a map.

Personally, I also find it easier to read diffs if we have seperate files. I always get a bit confused if a change is happening up in <google-map-marker> or down in <google-map> since they're part of the same google-map.html file.

P.S. I'd open an issue about the autocomplete functionality you're interested in, there are a few different ways that implementation can pan out if we choose to expose the full autocomplete widget or just the JS service you could wire up to your own input boxes.

[mbykovskyy]

Ok I'll open a new issue for autocomplete component. Should this issue stay open until there's an agreed convention for naming and separating components? Like you said google-map.html contains two components while the rest of the components/services live in their own file.

[bamnet]

Let's let @ebidel || @addyosmani weigh in here.

[ebidel]

Generally, we prefer separate files for separate functionality. That's the majority case. However, for something like google-map and google-map-marker, the latter is not useful by itself so it makes sense to define it alongside google-map. Given that, a separate import would be wasteful and unnecessary.