Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Magnum cluster upgrade API #2031

Closed
jkmw opened this issue Sep 28, 2020 · 5 comments
Closed

Support Magnum cluster upgrade API #2031

jkmw opened this issue Sep 28, 2020 · 5 comments

Comments

@jtopjian
Copy link
Contributor

@jkmw Thank you for opening this. Please note that API documentation alone is not enough to support a feature being added. More information is here in our Contributor Tutorial. Let me know if you have any questions.

@jkmw
Copy link
Contributor Author

jkmw commented Sep 28, 2020

@jtopjian well, I have linked the code location now, so that it's clear that my change is supported.

I hope this is enough?

@jtopjian
Copy link
Contributor

Thanks.

In your PR, you are defining a new struct with a set of fields. Do you know where these fields are defined? In other words, how do we know that max_batch_size is a valid field to be sent in a JSON request?

@jkmw
Copy link
Contributor Author

jkmw commented Sep 29, 2020

I have now also linked the class, which contains all parameters that are used for the upgrade call. These are in the same file as the reference to calling the controller.

I assumed that the rest of the context is self-evident from the file 🤷

@jtopjian
Copy link
Contributor

Implemented in #2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants