Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for identity v3 OS-FEDERATION mappings extension #2461

Closed
5 tasks done
emilmaruszczak opened this issue Sep 6, 2022 · 7 comments
Closed
5 tasks done

Add support for identity v3 OS-FEDERATION mappings extension #2461

emilmaruszczak opened this issue Sep 6, 2022 · 7 comments

Comments

@emilmaruszczak
Copy link
Contributor

emilmaruszczak commented Sep 6, 2022

As part of the OS-FEDERATION keystone extension has added a mappings api.
Add support for it.

docs
code

  • List mappings
  • Create mapping
  • Get mapping
  • Update mapping
  • Delete mapping
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Thank you for reporting your first issue! Be sure that we will be looking at it, but keep in mind
this sometimes takes a while.
Please let the maintainers know if your issue has not got enough attention after a few days.
If any doubt, please consult our issue tutorial.

@emilmaruszczak
Copy link
Contributor Author

emilmaruszczak commented Sep 28, 2022

I do have all the operations implemented, just decided to push them one by one so they are not dependent on each other and it's easier for the merger to handle ;).

@shaardie
Copy link

We are also interested in this feature and thought about implementing it our-self and bringing it upstream. And were happy to see, that there was already work done for that.

What is the current status of this? I see the List Mappings is already present. What about the other calls?

@emilmaruszczak Is it still your plan to create PR for them?

@emilmaruszczak
Copy link
Contributor Author

@shaardie The logic and unit tests are implemented, I will PR them in shortly, after adding the acceptance tests.

@shaardie
Copy link

@shaardie The logic and unit tests are implemented, I will PR them in shortly, after adding the acceptance tests.

Thanks, we are looking forward to it 👍

@mandre
Copy link
Contributor

mandre commented Mar 2, 2023

@emilmaruszczak looks like you've implemented it all. Is there anything left, or can we close this issue now?

@emilmaruszczak
Copy link
Contributor Author

@emilmaruszczak looks like you've implemented it all. Is there anything left, or can we close this issue now?

Yes, all is implemented now. Thank you for reviews and your work.

@mandre mandre closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants