Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gomacro #132

Closed
fiorix opened this issue Jul 16, 2018 · 4 comments
Closed

Update gomacro #132

fiorix opened this issue Jul 16, 2018 · 4 comments

Comments

@fiorix
Copy link

fiorix commented Jul 16, 2018

gomacro is one of the vendor'ed dependencies of gophernotes. I'd like to update it to get cosmos72/gomacro#33 in gophernotes.

Tested locally, works as expected.

@cosmos72
Copy link
Member

I happen to know :)

For the moment, gophernotes uses gomacro stable branch not to pull in (experimental) generics - but that's not a problem, as I backported the same fix also to gomacro stable

@fiorix
Copy link
Author

fiorix commented Jul 16, 2018

Ah. You're ahead of me. I didn't even realize :)

I guess you can drop my pull request then. Can you release a new tag v1.0.0-RC2 or something?

@cosmos72
Copy link
Member

cosmos72 commented Jul 16, 2018

Yes, it's time for a new release - there are already a lot of changes and improvements since the last one. Thanks for reminding :)

I am a bit busy RL, but I should manage in the next days.

@QuLogic
Copy link
Contributor

QuLogic commented Aug 19, 2018

Any time for a new tag perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants