Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react-storybook #24

Closed

Conversation

zeroasterisk
Copy link

Checkout the new package and setup instructions on the README...

See if you like the idea...
React Storybook is awesome, and it can auto-publish to github pages for you....

@gor181
Copy link
Collaborator

gor181 commented Sep 1, 2016

Heya @zeroasterisk ,

WOW! This would be awesome. I have tried to boot it up by running npm run storybook:

image

Building doesn't help prior running:

image

It seems to work fine if I just run examples with npm start and open localhost:8000.

It could be that the issue is related as I'm using export instead of module.exports or similar.

Thoughts?

Thanks,

@zeroasterisk
Copy link
Author

Your npm start does some hijackery on the package.json --> aliasify --> it makes this into the package. (via that starter package you use)

The way I got around it, is documented in your readme... via npm link

cd <repo-root>
npm build
npm link
npm link react-chartjs-2

Though... I think a better solution might be to directly include via a relative path vs. the react-chartjs-2 package name... makes the examples a little less "real world" but makes dev simpler.

@gor181
Copy link
Collaborator

gor181 commented Sep 1, 2016

Ah! Yeh, agreed. Would be awesome to require the examples in a relative manner. I can do it in another branch for examples folder, can you make story book to use relative paths?

I appreciate your help, storybook is niceee

@jerairrest
Copy link
Collaborator

Can master get merged into this? :) thanks!

@jerairrest
Copy link
Collaborator

Well I guess we'll consider this not mergeable :(

@jerairrest jerairrest closed this Apr 16, 2017
@zeroasterisk
Copy link
Author

Ha. Sorry I never saw the previous message. Let me dust this off and see if I can easily revive it.

@jerairrest
Copy link
Collaborator

Awesome man! Looking forward to the PR.

@zeroasterisk zeroasterisk mentioned this pull request Apr 17, 2017
@zeroasterisk
Copy link
Author

easy peasey #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants