Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question/request: Split cache library from CLI tool? #240

Open
mwernaert opened this issue Feb 4, 2024 · 0 comments
Open

Question/request: Split cache library from CLI tool? #240

mwernaert opened this issue Feb 4, 2024 · 0 comments

Comments

@mwernaert
Copy link
Contributor

Hi @gordalina

Are you open to the idea of splitting this package up in a tool package and a separate library package?

I currently use this package purely as a library and I reckon others do too. The main reason why I wish there was a separate library package is because some of the (bigger) dependencies are only required for the CLI tool.

If the library code was a separate package it would only require hollodotme/fast-cgi-client, psr/log, symfony/process, symfony/http-*.
And, although \CacheTool\CacheTool has a dependency on \Monolog\Logger, it is only used as a default logger. I think it would make more sense to use a \Psr\Log\NullLogger instance here.

Also, it would enable library consumers to upgrade to Symfony 7 (or future major versions) more easily, because consolidation/self-update is not blocking a major version upgrade in that case.

I'm happy to help with a PR. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant