Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log API requests for future machine learning features #940

Open
russtuck opened this issue Jul 3, 2023 · 1 comment · Fixed by #1036 · May be fixed by #968
Open

Log API requests for future machine learning features #940

russtuck opened this issue Jul 3, 2023 · 1 comment · Fixed by #1036 · May be fixed by #968
Labels
Feature A new feature

Comments

@russtuck
Copy link
Member

russtuck commented Jul 3, 2023

I did a little searching for best practices in handling .NET logs. Here are some notes on what I found (with references at the bottom).

  1. They were all focused on using logs to debug errors in production. That's great, but it's not what we're doing here. Logging for debugging might include this, but would also include other things.

  2. Logging to a database is one of the top 3 options. Another is logging to a separate service that other things can listen to if they want the logs. And of course the other is log files.

We could adopt one of the log saving systems recommended in the references below, but then we'd also need to figure out how to get the data into a machine learning system. Or we can simply save it into the DB, where it's also easy to query it for ML.

My vote is to start logging to the database, and see how it goes. If the DB shows signs of stress as a result, we can disable it and then try another option.

References:
https://michaelscodingspot.com/logging-in-dotnet/
https://stackify.com/csharp-logging-best-practices/
https://raygun.com/blog/c-sharp-logging-best-practices/

Originally posted by @russtuck in #968 (comment)

@russtuck russtuck added the s23 label Jul 3, 2023
@amos-cha amos-cha added Feature A new feature 5 Points To measure progress labels Jul 13, 2023
@amos-cha amos-cha linked a pull request Jul 13, 2023 that will close this issue
@EjPlatzer EjPlatzer removed 5 Points To measure progress s23 labels Jul 25, 2023
@EjPlatzer EjPlatzer linked a pull request Jul 25, 2023 that will close this issue
@russtuck russtuck reopened this Apr 18, 2024
@russtuck
Copy link
Member Author

#1036 is a great first step, but it doesn't log all the needed data, and doesn't save it long enough to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature
Projects
None yet
3 participants