Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile polygon clipping is inefficient #11

Open
gordonwoodhull opened this issue Oct 5, 2023 · 0 comments
Open

Tile polygon clipping is inefficient #11

gordonwoodhull opened this issue Oct 5, 2023 · 0 comments

Comments

@gordonwoodhull
Copy link
Owner

Related to #3 flag for controlling tile polygon clipping, the implementation of tile polygon clipping is inefficient because a clipping path is created for every tile.

There only needs to be a clipping path for each base polygon, because the clip path is relative to the tile center point.

The easy way to implement this is to put the SVG clip paths into a hash and assign an ID. However, for clarity and for debugging purposes, it would be better for polygons to identify their base polygon name/ID, and use that to id their clipPath and the association with tiles.

Then there also the cube grid case, where only one clip path is needed because the square is transformed three ways.

@gordonwoodhull gordonwoodhull added this to the merge upstream milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant