Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Jade Necessary? #16

Closed
rapind opened this issue Dec 3, 2015 · 4 comments
Closed

Is Jade Necessary? #16

rapind opened this issue Dec 3, 2015 · 4 comments

Comments

@rapind
Copy link

rapind commented Dec 3, 2015

Don't get me wrong. I love Jade (and HAML and Slim), but you'll only even be using it for the entry point on the server so it'll never be larger than this:
https://github.com/GordyD/3ree/blob/master/server/views/index.jade

It's not really part of this stack and seems unnecessary to include it just for this one view. Besides you're using JSX (HTML) on the react side, so now you've got multiple syntax for rendering.

Just an opinion though!

@GordyD
Copy link
Owner

GordyD commented Dec 6, 2015

Hey. This is a good point, it does seem superfluous upon reflection. I'll swap it out for standard HTML template so that this aspect is simplified and easier to understand for people without Jade knowledge.

Thank you for your input!

@rapind
Copy link
Author

rapind commented Dec 6, 2015

Awesome. And thanks for putting this together!

@GordyD GordyD mentioned this issue Dec 7, 2015
@GordyD
Copy link
Owner

GordyD commented Dec 7, 2015

Please check out this PR. I chose the ejs view template engine to render plain html with the local variables that are passed in via the call to .render(view, locals).

Let me know your thoughts.

@GordyD
Copy link
Owner

GordyD commented Dec 8, 2015

This PR has now been closed. I am going to close this issue but if you notice anything else feel free to open a new one! :)

@GordyD GordyD closed this as completed Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants