Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESlint #24

Closed
pcanterini opened this issue Dec 9, 2015 · 4 comments
Closed

Add ESlint #24

pcanterini opened this issue Dec 9, 2015 · 4 comments

Comments

@pcanterini
Copy link
Contributor

It might be a good idea to add ESlint and EditorConfig to help with consistency.

I've recently started using standardjs but it's probably a preference thing based on your code style.

@GordyD
Copy link
Owner

GordyD commented Dec 9, 2015

Good call!

I am on the fence as to which tool (ESLint and Standard) is the best option. On the one hand, seeing standard (thanks for sharing this), it looks great because it is just plug and play - it will not detract from the main focus of this repo. But on the other, as this is a demo/bootstrap repo - it might make sense to use a linting tool that allows for custom rules (although I wouldn't want to get too bogged down in debate so I would probably opt for using Airbnb's eslint rules).

Which do you think is best here?

@pcanterini
Copy link
Contributor Author

I vote for consistency too so if you think extending from Airbnb's presets is the closest I'm fine with that. 👍

@GordyD
Copy link
Owner

GordyD commented Dec 9, 2015

Ok. EsLint + Airbnb + EditorConfig sounds good.

For EditorConfig I think the most important rule is:

[*.js]
indent_style = space
indent_size = 2

Anything else?

@pcanterini
Copy link
Contributor Author

LGTM

@GordyD GordyD closed this as completed Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants