Investigate curl -N flag, update shlibs

[client9]

Added in

f451dc9#diff-83752e6cf679642f9650d58b739cb2c3

the command for curl added the -N flag

This turns off curl buffering. That's fine, but its not clear what problem this solved. (or maybe I missed it).

I don't see this in similar shell downloaders like:

https://github.com/golang/dep/blob/master/install.sh

Just curious on why, and to make sure it's in older curl versions.

@caarlos0 any ideas here on why it was added?

If it's needed, then I need to update client9/shlibs (no problem, just another thing to do).

n

[caarlos0]

I believe it is to reduce the risk of executing partially downloaded files, not really sure though... @flyinprogrammer ?

[flyinprogrammer]

The -N came from here i believe: #38
My commit just happened to rebuild the scripts because of the CI process? I believe?
It certainly wasn’t intentional, happy to help dig in more if it’s an issue.

[client9]

ah good find @flyinprogrammer I'll take a look... not clear why that person was having problems and why buffereing would be a problem. Looks like it might be masking another issue.

[caarlos0]

yeah, I was like 'uh, ok then' and didn't investigate it further, my bad...

[client9]

No worries @caarlos0

The README file now has some references to 4 other shell installers. I couldn't find any that use -N

This may have been caused by piping curl to another program and shell pipe behavior with part of the pipe closing. I don't think this done any more so it shouldn't be an issue.

n