Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser-action tries to download incorrect version of installer on armv6 #308

Closed
tenyo opened this issue Sep 30, 2021 · 7 comments · Fixed by #309
Closed

goreleaser-action tries to download incorrect version of installer on armv6 #308

tenyo opened this issue Sep 30, 2021 · 7 comments · Fixed by #309
Labels
enhancement New feature or request

Comments

@tenyo
Copy link

tenyo commented Sep 30, 2021

Hi, I'm trying to run gorelease-action on a 32-bit ARM machine (armv6 arch) and it's trying to download goreleaser_Linux_arm.tar.gz which doesn't exist.

Downloading https://github.com/goreleaser/goreleaser/releases/download/v0.180.3/goreleaser_Linux_arm.tar.gz
Error: Unexpected HTTP response: 404

The correct goreleaser binary in this case should be called goreleaser_Linux_armv6.tar.gz from looking at https://github.com/goreleaser/goreleaser/releases

@tenyo
Copy link
Author

tenyo commented Oct 1, 2021

Guessing that the problem is again in https://github.com/goreleaser/goreleaser-action/blob/master/src/installer.ts#L50

@crazy-max
Copy link
Member

Yes we don't handle arch variant atm.

@crazy-max
Copy link
Member

@tenyo Can you try with uses: goreleaser/goreleaser-action@master?

@tenyo
Copy link
Author

tenyo commented Oct 4, 2021

@crazy-max Thanks for the quick fix! It kinda worked but still failing in my case.
I see it's correctly identifying the arch (armv7) but that version of goreleaser doesn't exist, there's only armv6. So, I guess, the question is, will the goreleaser_Linux_armv6 binary work on armv7 (I would think so), in which case we can always download the armv6 version?

> Run goreleaser/goreleaser-action@master
Downloading https://github.com/goreleaser/goreleaser/releases/download/v0.180.3/goreleaser_Linux_armv7.tar.gz
Error: Unexpected HTTP response: 404

@crazy-max
Copy link
Member

I guess GoReleaser should produce v7 variant binaries instead. cc @caarlos0

@caarlos0
Copy link
Member

caarlos0 commented Oct 4, 2021

Yeah, just need to add to the config

@tenyo
Copy link
Author

tenyo commented Oct 6, 2021

Thanks a lot guys! It downloads the correct version now after the last release which includes the v7 binary 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants