Fixed some header links, added note about Golang version used. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a side note for discussion, I would like to find a way to improve the README to better describe how someone could derive the right value for PKG_CONFIG_PATH and related setup.
In the example, we have:
While
CC
andCXX
are fairly easy to found, it's harder to know for sure by whatarmhf
needs to be replaced and by whatarm-linux-gnueabihf
in/sysroot/linux/armhf/usr/lib/arm-linux-gnueabihf
is needed.I think for
armhf
a quick sentence to tell to replace byArch
column in supported platforms table. For the other one, I would like to add another columnTriplet
in the the same table. A sentence would then explain thatarm-linux-gnueabihf
should be replaced in the triplet.I was wondering also if we should just list the required values per platforms directly instead, does are fairly static and won't change often, so seems it could be a good improvements to add the direct values.