Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser check: run on every ci run? #1289

Closed
caarlos0 opened this issue Jan 7, 2020 · 4 comments · Fixed by #1435
Closed

goreleaser check: run on every ci run? #1289

caarlos0 opened this issue Jan 7, 2020 · 4 comments · Fixed by #1435
Labels
enhancement New feature or request

Comments

@caarlos0
Copy link
Member

caarlos0 commented Jan 7, 2020

a couple of ideas I had to make it more noticeable to users when they're using deprecated configs:

  1. warn at the end of goreleaser release
  2. instruct to have another step that runs on every commit doing goreleaser check, maybe make exit code != 0 when deprecated settings are being used

any thoughts?

@caarlos0 caarlos0 added the enhancement New feature or request label Jan 7, 2020
@stale
Copy link

stale bot commented Jan 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 21, 2020
@stale stale bot removed the wontfix This will not be worked on label Jan 26, 2020
@joemiller
Copy link

joemiller commented Feb 9, 2020

I like 2 because I could see incorporating it into a project's CI (eg: make lint or make test) if I wanted to block and alert someone to make changes.

@matthiasng
Copy link
Contributor

I agree with @joemiller.
For local testing, the output at the end of goreleaser release is fine, but inside a pipeline, a warning gets easily lost.

@caarlos0
How about goreleaser release --no-deprecated instead of an additional command ? I think this will simplify the implementation a lot. The disadvantage is that you cannot add it to you quality checks pipeline steps.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants