Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use Deploy Keys to deploy Homebrew taps #2027

Closed
AnomalRoil opened this issue Jan 20, 2021 · 4 comments
Closed

Add the ability to use Deploy Keys to deploy Homebrew taps #2027

AnomalRoil opened this issue Jan 20, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@AnomalRoil
Copy link

Is your feature request related to a problem?
Using a Personal Access Token (PAT) with repo rights to deploy the Homebrew taps is a security concern, see #2026

Describe the solution you'd like
Since Github does not allow to create PAT that are restricted to a few repository, but allows adding Deploy Keys to specific repositories, it might be interesting to have a way to provide a SSH Deploy Key instead of a Token for Homebrew deployment as was proposed in #1643 and for the same reasons.

Describe alternatives you've considered
We can use Machine User accounts to workaround the security issue, but it adds a significant extra burden (with the need to create and secure an extra account).

We can use a very hackish way using Github Apps Installation token, since these can be restricted to specific repo, it appears.

Additional context
I'll open a discussion on the topic shortly.

@AnomalRoil AnomalRoil added the enhancement New feature or request label Jan 20, 2021
@caarlos0
Copy link
Member

What was done on #1643 works on the brew pipe as well...

see #1650

@AnomalRoil
Copy link
Author

Yes, but the issue is that PA Token are too difficult to "restrict" in scope to a single repo, whereas Deploy Keys are highly specific to a repo and thus super useful for deployment.

@caarlos0
Copy link
Member

My understanding is that it would require us to change our impls to clone/commit/push the tap repo, as today we only use the github API.

Probably won't happen anytime soon as its a big rewrite on otherwise stable code.

Will keep in mind for v2 though.

Thanks!

@caarlos0 caarlos0 added this to the v2.0.0 milestone Feb 12, 2021
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2021
@caarlos0 caarlos0 modified the milestones: v2.0.0, v1.0.0 Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants