We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We added slack announcer support to our project with the following definition:
announce: slack: enabled: true message_template: 'Defaults to `{{ .ProjectName }} {{ .Tag }} is out! Check it out at {{ .GitURL }}/releases/tag/{{ .Tag }}' channel: '#kink' username: 'GoReleaser' icon_url: 'https://github.com/goreleaser/goreleaser/raw/939f2b002b29d2c8df6efd2d1f1d0b85c4ac5ee0/www/docs/static/logo.png'
then, we realized that there is a username and the token in the message that was sent by GoReleaser (we are using Gitlab, btw) like the following:
Defaults to `kink v0.1.4 is out! Check it out at https://gitlab-ci-token:SyYhsAghYFTvMoxw7GAg@gitlab.private.com/poc/kink.git/releases/tag/v0.1.4
I think we should avoid that somehow.
You can use the same announce section within your .goreleaser.yml, then run the release command.
announce
.goreleaser.yml
release
goreleaser version 0.177.0 commit: eb9950e794e60a8d1e3d7ad4616ccdd579fc2db3 built by: homebrew https://goreleaser.com
No response
The text was updated successfully, but these errors were encountered:
cc @Dentrax @caarlos0
Sorry, something went wrong.
yeah we should probably cleanup URLs, removing the auth from them
probably should add a CleanGitURL to the templates, and use it instead of .GitURL as default.
CleanGitURL
.GitURL
we could clean the url with something like:
u, err := url.Parse(gitURL) if err != nil { // handle } u.User = nil cleanGitURL := u.String()
may I do it @caarlos0 ?
sure, go ahead :)
caarlos0
Successfully merging a pull request may close this issue.
What happened?
We added slack announcer support to our project with the following definition:
then, we realized that there is a username and the token in the message that was sent by GoReleaser (we are using Gitlab, btw) like the following:
Defaults to `kink v0.1.4 is out! Check it out at https://gitlab-ci-token:SyYhsAghYFTvMoxw7GAg@gitlab.private.com/poc/kink.git/releases/tag/v0.1.4
I think we should avoid that somehow.
How can we reproduce this?
You can use the same
announce
section within your.goreleaser.yml
, then run therelease
command.goreleaser version
GoReleaser Check
Search
Code of Conduct
Additional context
No response
The text was updated successfully, but these errors were encountered: