Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides depends fails - should be dependencies #3721

Closed
3 tasks done
maraino opened this issue Jan 26, 2023 · 1 comment
Closed
3 tasks done

Overrides depends fails - should be dependencies #3721

maraino opened this issue Jan 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working docs A problem or enhancement in documentation
Milestone

Comments

@maraino
Copy link

maraino commented Jan 26, 2023

What happened?

The last version of GoReleaser (1.14.1) fails if we add an override like this in the nfpms section:

nfpms:
  - ...
    overrides:
      deb:
        depends:
          - some-package

The message displayed looks like this:

  ⨯ release failed after 0s                  error=yaml: unmarshal errors:
  line 127: field depends not found in type config.NFPMOverridables

Using dependencies instead of depends works as expected.

How can we reproduce this?

Use depends as is documented at

overrides:
# The depends override can for example be used to provide version
# constraints for dependencies where different package formats use
# different versions or for dependencies that are named differently.
deb:
depends:
- baz (>= 1.2.3-0)
- some-lib-dev
# ...
rpm:
depends:
- baz >= 1.2.3-0
- some-lib-devel
# ...

goreleaser version

$ goreleaser -v
goreleaser version 1.14.1
commit: 7be70934534b5c9798b6ab1b7b3e5c35df7e8b2e
built at: 2023-01-02T13:53:59Z
built by: goreleaser
goos: linux
goarch: amd64
module version: v1.14.1, checksum: h1:b+cW4BSDL5Ii32scSX8IoXrnpwHIItXgZyMskBhNK8s=

https://goreleaser.com
root@42040088c796:/go/src/github.com/smallstep/step-kms-plugin# goreleaser --version
goreleaser version 1.14.1
commit: 7be70934534b5c9798b6ab1b7b3e5c35df7e8b2e
built at: 2023-01-02T13:53:59Z
built by: goreleaser
goos: linux
goarch: amd64
module version: v1.14.1, checksum: h1:b+cW4BSDL5Ii32scSX8IoXrnpwHIItXgZyMskBhNK8s=

https://goreleaser.com

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

goreleaser check shows the same error, but I cannot submit this without checking that box, it is required:

$ goreleaser check
  • loading config file                              file=.goreleaser.yml
  ⨯ command failed                                   error=yaml: unmarshal errors:
  line 127: field depends not found in type config.NFPMOverridables
  line 130: field depends not found in type config.NFPMOverridables
@maraino maraino added bug Something isn't working triage Issue pending triage by one of the maintainers labels Jan 26, 2023
@caarlos0
Copy link
Member

docs issue, fixed

thanks for noticing 🙏

@caarlos0 caarlos0 added docs A problem or enhancement in documentation and removed triage Issue pending triage by one of the maintainers labels Jan 28, 2023
@caarlos0 caarlos0 added this to the v1.15.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs A problem or enhancement in documentation
Projects
None yet
Development

No branches or pull requests

2 participants